Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Do not create containers / buckets automatically #618

Open
2 of 7 tasks
nicolasmure opened this issue Jun 19, 2019 · 0 comments
Open
2 of 7 tasks

[1.0] Do not create containers / buckets automatically #618

nicolasmure opened this issue Jun 19, 2019 · 0 comments
Assignees
@KevinArtus @FlorianQgb @AntoineGonzalez
Labels
BC breaks
Milestone
v1.0

Comments

@nicolasmure
Copy link
Contributor

nicolasmure commented Jun 19, 2019 •
edited
Loading

We were previously (on 0.x) creating the containers / buckets automatically when using adapters. This can lead to security flaws in case where the bucket is not created as the adapter's user want to.

Buckets creation is beyound Gaufrette scope and so should not be managed by Gaufrette. Buckets used by Gaufrette shoud be created by the developer (or any other way) and should be properly configured for the developer needs.

Thus, Gaufrette should not automatically create buckets when they do not exist. This will remove the create flag passed to adapters's constructor, and the usage of an adapter on an unexisting bucket should raise an exception.

TODO
@nicolasmure nicolasmure added this to the v1.0 milestone Jun 19, 2019
nicolasmure added a commit that referenced this issue Jun 20, 2019
@nicolasmure
do not automatically create container
b3c5686 
The container creation is not the responsibility of Gaufrette as it
could lead to security flaws. The user should create the container on
its own (manually or by using the OpenStack SDK).

See #618 for more details.
@nicolasmure nicolasmure mentioned this issue Jun 28, 2019
Merged
6 tasks
nicolasmure added a commit to nicolasmure/Gaufrette that referenced this issue Jun 28, 2019
@nicolasmure
Do not automatically create the base directory for Local adapter
b7a7bea 
Related to KnpLabs#618

We throw an exception when building the adapter if the specified base
directory does not exist. The write methods can still create sub
directories (eg /base/my/very/deep/dir), however the /base directory
have to be present.

The developer should create this directory on its own before using the
adapter.
@nicolasmure nicolasmure mentioned this issue Jun 28, 2019
Merged
nicolasmure added a commit to nicolasmure/Gaufrette that referenced this issue Jul 1, 2019
@nicolasmure
do not create container for AzureBlobStorage
06e3ffb 
Related to KnpLabs#618.

Container creation is out of Gaufrette scope. The container should be
created by the deleveloper on its own.
Thus, the multi container mode has been removed, as it was creating
containers on the fly.
@nicolasmure nicolasmure mentioned this issue Jul 1, 2019
Open
1 task
nicolasmure added a commit to nicolasmure/Gaufrette that referenced this issue Jul 3, 2019
@nicolasmure
do not create container for AzureBlobStorage
d389a79 
Related to KnpLabs#618.

Container creation is out of Gaufrette scope. The container should be
created by the deleveloper on its own.
Thus, the multi container mode has been removed, as it was creating
containers on the fly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinArtus KevinArtus

@FlorianQgb FlorianQgb

@AntoineGonzalez AntoineGonzalez

Labels
BC breaks
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
4 participants
@KevinArtus @nicolasmure @FlorianQgb @AntoineGonzalez