Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error system #13

Open
jonpas opened this issue Feb 19, 2019 · 1 comment
Open

Improve Error system #13

jonpas opened this issue Feb 19, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jonpas
Copy link
Collaborator

jonpas commented Feb 19, 2019

Example:

error: Failed to build PBO:
Failed to parse config:
In line addons/weapon_sniper_c/config.cpp:19:

  class CfgSoundShaders {
  ^

Unexpected token "", expected: "delete", "[a-zA-Z0-9_]", "class"

The Failed to build PBO: with the colon at the end is very confusing, as one expects to read the PBO name there. However that is a job of whatever is using/calling armake2. Same goes for further lines until the actual source.

An idea would be to prepend those with a number, it's supposed to be kind of a stack trace if I understand the meaning of this form of error output, numbers like Rust's backtrace would be ideal. And obviously no colons in that case.

It's also self-explanatory that PBO failed to build if you have a red error which also tells you what what exactly failed (parsing, binarizing... etc.).

@jonpas jonpas added the enhancement New feature or request label Feb 19, 2019
KoffeinFlummi added a commit that referenced this issue May 13, 2019
@KoffeinFlummi
Copy link
Owner

I removed some of the more general top-level error messages, but I think the error system needs an overhaul anyways. Rust has the tools to build a proper Error stack, which would be more useful when using armake as a library as well.

@KoffeinFlummi KoffeinFlummi self-assigned this May 13, 2019
@KoffeinFlummi KoffeinFlummi changed the title Error trace is confusing Improve Error system May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants