Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targetSymbol in Eval::ImportCoin() must be checked for non empty #480

Closed
dimxy opened this issue Aug 19, 2021 · 3 comments
Closed

targetSymbol in Eval::ImportCoin() must be checked for non empty #480

dimxy opened this issue Aug 19, 2021 · 3 comments

Comments

@dimxy
Copy link
Collaborator

dimxy commented Aug 19, 2021

targetSymbol field in the import transaction is compared to various values to determine the import type. One of the cases is the check against the ASSETCHAINS_SELFIMPORT chain var and treated as a gateway import tx. If both targetSymbol and ASSETCHAINS_SELFIMPORT are empty the code flow enters gateway import statements what it should not do.
Both ASSETCHAINS_SELFIMPORT targetSymbol should be checked as non-empty in Eval::ImportCoin() before allowing to go further in the import tx validation.
(should ASSETCHAINS_SELFIMPORT be checked to a specific value like "GATEWAY"?)

@dimxy
Copy link
Collaborator Author

dimxy commented Aug 19, 2021

fixed in the tokel branch.
thanks Decker for finding this

@dimxy
Copy link
Collaborator Author

dimxy commented Oct 12, 2022

not yet fixed in dev

@dimxy
Copy link
Collaborator Author

dimxy commented Oct 12, 2022

fixed in PR #559

who-biz pushed a commit to who-biz/komodo that referenced this issue Mar 14, 2023
@dimxy dimxy closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant