Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

komodod crash in mining code #555

Closed
dimxy opened this issue Jul 18, 2022 · 1 comment
Closed

komodod crash in mining code #555

dimxy opened this issue Jul 18, 2022 · 1 comment

Comments

@dimxy
Copy link
Collaborator

dimxy commented Jul 18, 2022

With mining on, komodod sometimes crashes (observed on a dedicated node, with no ASIC).
Here is the backtrace:

Core was generated by `./komodod -gen -genproclimit=1 -pubkey=...'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  BitcoinMiner (pwallet=<optimized out>) at miner.cpp:1624
1624                                    index_vector[i] = eq.sols[s][i];
[Current thread is 1 (Thread 0x7f442bfff700 (LWP 26388))]

It looks like that the index 's' ranging from 0 from eq.nsols may get over eq.sols upper bound equal to MAXSOLS.
To fix this, the suggestion is to have the range for 's' from 0 to min(MAXSOLS, eq.nsols)

@dimxy
Copy link
Collaborator Author

dimxy commented Mar 29, 2023

fixed in #559

@dimxy dimxy closed this as completed Mar 29, 2023
who-biz pushed a commit to who-biz/komodo that referenced this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant