-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI sync semantic kompakkt and kompakkt Metadata #42
Comments
Thanks Senya, this is a good issue to resolve. I think we should aim to align this part of the presentation thus:
Can you make two new mockups based on the above and paste one here for Kompakkt changes & one also in SK / Gitlab issue for the SK changes that need to be made there. |
Thanks for this comment @Grizzly127 - I think we should vote which option we like better - a vertical or horizontal wizard and align both to the same style. @HeyItsBATMAN @ZetOE - what's your opinion here? I personally I like the "horizontal" style of the SK version a bit better (the other long scroll thing somehow seems endless and might put users off of exploring all options), but perhaps it's also a matter of making the data a bit more lean for Kompakkt (I think in SK we already reduced it a lot, so nothing to cut here, but perhaps we can also add some new bits here especially when it comes to possibility to add new people, or new things in the database if they are not already findable with the search option). If there is less data entry fields, then maybe the long scroll is also not so bad. By making the data more lean, I mean for example all these fields under General Information: Statement We don't have these in SK, and I wonder what's their function and how many people use them? @HeyItsBATMAN @ZetOE do you have any remarks here - I feel like I've never seen tags or discipline being used as navigation / exploration filters, so what are they for? If we go through all metadata fields one by one and identify if some can be cut, then perhaps you can try a redesigned mockup @Grizzly127 that puts Kompakkt's structure in something that looks more like SK? Or vice versa. If the Kompakkt's structure is simplified, we can try to put SK's wizard into the long form scroll. |
I'm strongly in favor of the SK style. The long scroll of Kompakkt really complicates things, and also makes it unnecessarily difficult to see what's missing.
@ZetOE can probably tell more about the purposes of each of those. But I think the design of SK can be applied to Kompakkt even without removing fields. |
@Grizzly127 As discussed today, the cases when the same person or institution have more than one role, the roles can be listed on one line with a comma or & sign, eg: Rights owner & Creator: Lozana Rossenova ... The address info is then listed below (only once). Also from discussion today with @Grizzly127 & @vmalieske - Next button will be used as is currently in SK & Kompakkt - so it only progresses to the next stage in the stepper wizard and not through individual metadata. To check the different metadata sections, users can navigate via the sidebar. The Next button will be titled "Finalize" and will be greyed out until the users complete at least the 3 mandatory fields, then it will be possible to progress to the final step in the stepper. We will also test the inclusion of a "Save" button in the bottom area of the wizard, so that users feel more secure they won't lose their metadata if they don't immediately finish the upload. |
Upload MetadataThis is my suggestion for the design for the upload formular:
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Finalize upload
![]() ![]() |
Sounds like a good idea to me. In general, we could include the information of all required fields here (on the finalize page), and re-use the design/component from the detail page for this? |
@Grizzly127 see my comment in Gitlab, i think the Grid presentation is a bit confusing. I think it would look better if we keep all roles on one line, separated by a comma, but maybe we move the contact name to a new line to avoid awkward gaps. |
@Grizzly127 & @HeyItsBATMAN - one more question regarding the metadata upload form - are all the fields really the same between Kompakkt and SK - so icluding creation & the related properties like software, technique, etc? Perhaps it's worth thinking about a slightly alternative way to add these because in SK they are coming from Wikibase, in Kompakkt they can be entered manually, so the entry fields cannot be exactly the same as in SK. |
Right now, this is the Creation part for kompakkt: and this for semantic kompakkt: How do the fields look like if the information is coming from Wikibase? I'm not sure if I have seen it somewhere yet. |
@Grizzly127 The Wikibase entries have the magnifier glass because it's only allowing search of existing entries. In Kompakkt I think you can just enter plain text? Or can you also search existing entries? Not sure, but probably you don't need the magnifier glass there. And maybe "Program" in Kompakkt can also be renamed Software to keep it more similar to SK. It also looks like creation is mandatory in Kompakkt, but it's not in SK, so that can be something further aligned. What fields are mandatory, what not, etc. |
- update licence view - update persons and institutions regarding issue Kompakkt#42
okay, then there will be just small differences:
![]() kompakkt:
![]() |
Great, thanks, to the questions below:
Equipment is added to Wikibase, but it's a free-text field, so the user can just add anything here and it's saved as plain text (not data) in Wikibase, this is a compromise because we didn't want to limit what kind of equipment users can enter. It's somewhat similar to what would happen in Kompakkt I assume.
Yes, this sounds good to me. Additionally as discussed today, you may need to consider some additional templates that specify how users add new 'entities' in Kompakkt itself, which wouldn't exist in SK because we don't need it for WB. |
@Grizzly127 comments below:
Not sure if this can actually work with out Angular framework - @vmalieske can you confirm? If yes, great.
Question - will the form dynamically adjust if a person is chosen vs institution? E.g. if a person is chosen we only need Email address & Phone; if instittuion - maybe only physical address? If the form stays exactly the same, do we really need to make a distinction between person / institution? We could also get rid of this extra tick box if nothing else is determined by it. Additionally, let's adjust the text to: "Email address" and "Phone number" (with spaces). Can we get rid of "Note" - why do we need it? Let's reduce complexity as much as possible. The rest of the form looks good. Not sure if we need to add the email address in the Section that says "Creator" / "Rightsowner" below the "Add" button. The name should be just enough & the contact info - if it's available - will simply be displayed in the object page. That should be enough I think. It will make it easier to be compatible with SK as well. |
@Grizzly127 comments below:
I am in favor of keeping this more minimal - what do you think @HeyItsBATMAN @ZetOE? For me just a title of the object, link to Wikidata or another external link would be sufficient. I think the link text should be more description, e.g.: Users should be able to add more than one link. What other information is otherwise added via Kompakkt? @Grizzly127 can you provide a bullet list below and we can discuss line by line if we can get rid of it all, or we keep a few. It's important to check how much is this feature actually used in the current version of Kompakkt before replicating all of it, I think. |
If the user adds a related physical object the following information can be filled out:
![]()
![]()
![]()
![]()
![]()
![]()
![]()
![]()
![]() |
Persons and InstitutionsUnfortunately, I haven't got as far as I wanted to, but this is my current state:
|
Creation date can only be one. |
I think it can work like this for the user, it works like this on other platforms as well. And we reduce the number of input fields. If we get the feedback that it is confusing, we can still change it.
And if it is a new person, the user can choose if it is a person or institution, right? Three small things:
|
* Broken state, with the following migration steps: ```bash npm i --lockfile-version 3 --frozen-lockfile ng update @angular/{cdk,cli,core,material}@15 ng update @angular/{cdk,cli,core,material}@16 ng update @angular/{cdk,cli,core,material}@17 ng generate @angular/material:mdc-migration ng update @angular/material@17 ncu -u ``` ▸ Remove Browserslist configuration files that matches the Angular CLI default configuration. Migration completed (No changes made). ▸ Remove exported `@angular/platform-server` `renderModule` method. The `renderModule` method is now exported by the Angular CLI. Migration completed (No changes made). ▸ Remove no longer needed require calls in Karma builder main file. Migration completed (No changes made). ▸ Update TypeScript compiler `target` and set `useDefineForClassFields`. These changes are for IDE purposes as TypeScript compiler options `target` and `useDefineForClassFields` are set to `ES2022` and `false` respectively by the Angular CLI. To control ECMA version and features use the Browerslist configuration. UPDATE tsconfig.json (1550 bytes) Migration completed (1 file modified). ▸ Remove options from 'angular.json' that are no longer supported by the official builders. Migration completed (No changes made). ** Executing migrations of package '@angular/cdk' ** ▸ Updates the Angular CDK to v15. ✓ Updated Angular CDK to version 15 Migration completed (No changes made). ** Executing migrations of package '@angular/core' ** ▸ In Angular version 15, the deprecated `relativeLinkResolution` config parameter of the Router is removed. This migration removes all `relativeLinkResolution` fields from the Router config objects. UPDATE src/app/app-routing.module.ts (2163 bytes) Migration completed (1 file modified). ▸ Since Angular v15, the `RouterLink` contains the logic of the `RouterLinkWithHref` directive. This migration replaces all `RouterLinkWithHref` references with `RouterLink`. Migration completed (No changes made). ** Executing migrations of package '@angular/material' ** ▸ Updates the Angular Material to v15. ✓ Updated Angular Material to version 15 ** Executing migrations of package '@angular/cli' ** ▸ Remove 'defaultProject' option from workspace configuration. The project to use will be determined from the current working directory. Migration completed (No changes made). ▸ Replace removed 'defaultCollection' option in workspace configuration with 'schematicCollections'. Migration completed (No changes made). ▸ Update the '@angular-devkit/build-angular:server' builder configuration to disable 'buildOptimizer' for non optimized builds. Migration completed (No changes made). ** Executing migrations of package '@angular/cdk' ** ▸ Updates the Angular CDK to v16. ✓ Updated Angular CDK to version 16 Migration completed (No changes made). ** Executing migrations of package '@angular/core' ** ▸ In Angular version 15.2, the guard and resolver interfaces (CanActivate, Resolve, etc) were deprecated. This migration removes imports and 'implements' clauses that contain them. UPDATE src/app/guards/authenticated.guard.ts (417 bytes) UPDATE src/app/resolvers/profile-page-resolver.ts (684 bytes) Migration completed (2 files modified). ▸ As of Angular v16, the `moduleId` property of `@Component` is deprecated as it no longer has any effect. Migration completed (No changes made). ** Executing migrations of package '@angular/material' ** ▸ Updates the Angular Material to v16. ✓ Updated Angular Material to version 16 Migration completed (No changes made). ** Executing migrations of package '@angular/cli' ** ▸ Replace usages of '@nguniversal/builders' with '@angular-devkit/build-angular'. Migration completed (No changes made). ▸ Replace usages of '@nguniversal/' packages with '@angular/ssr'. Migration completed (No changes made). ▸ Replace deprecated options in 'angular.json'. UPDATE angular.json (3643 bytes) Migration completed (1 file modified). ** Executing migrations of package '@angular/cdk' ** ▸ Updates the Angular CDK to v17. ✓ Updated Angular CDK to version 17 Migration completed (No changes made). ** Executing migrations of package '@angular/core' ** ▸ Angular v17 introduces a new control flow syntax that uses the @ and } characters. This migration replaces the existing usages with their corresponding HTML entities. UPDATE src/app/pages/static-pages/contact/contact.component.html (2021 bytes) UPDATE src/app/pages/static-pages/privacy/privacy.component.html (13002 bytes) UPDATE src/app/pages/static-pages/consortium/consortium.component.html (1491 bytes) Migration completed (3 files modified). ▸ Updates `TransferState`, `makeStateKey`, `StateKey` imports from `@angular/platform-browser` to `@angular/core`. Migration completed (No changes made). ▸ CompilerOption.useJit and CompilerOption.missingTranslation are unused under Ivy. This migration removes their usage Migration completed (No changes made). ** Executing migrations of package '@angular/material' ** ▸ Updates Angular Material to v17. Cannot update to Angular Material v17 because the project is using the legacy Material components that have been deleted. While Angular Material v16 is compatible with Angular v17, it is recommended to switch away from the legacy components as soon as possible because they no longer receive bug fixes, accessibility improvements and new features. Read more about migrating away from legacy components: https://material.angular.io/guide/mdc-migration Files in the project using legacy Material components: - /src/app/app.module.ts - /src/app/components/actionbar/actionbar.component.ts - /src/app/components/auth-dialog/auth-dialog.component.ts - /src/app/components/grid-element/grid-element.component.ts - /src/app/components/metadata/entity/entity.component.ts - /src/app/components/metadata/institution/institution.component.ts - /src/app/components/metadata/person/person.component.ts - /src/app/components/navigation/navbar/navbar.component.ts - /src/app/dialogs/confirmation-dialog/confirmation-dialog.component.ts - /src/app/dialogs/edit-entity-dialog/edit-entity-dialog.component.ts - /src/app/dialogs/entity-rights-dialog/entity-rights-dialog.component.ts - /src/app/dialogs/entity-settings-dialog/entity-settings-dialog.component.ts - /src/app/dialogs/explore-compilation-dialog/explore-compilation-dialog.component.ts - /src/app/dialogs/explore-entity/explore-entity-dialog.component.ts - /src/app/dialogs/forgot-password-dialog/forgot-password-dialog.component.ts - /src/app/dialogs/forgot-username-dialog/forgot-username-dialog.component.ts - /src/app/dialogs/group-member-dialog/group-member-dialog.component.ts - /src/app/dialogs/password-protected-dialog/password-protected-dialog.component.ts - /src/app/dialogs/register-dialog/register-dialog.component.ts - /src/app/dialogs/reset-password-dialog/reset-password-dialog.component.ts - /src/app/dialogs/upload-application-dialog/upload-application-dialog.component.ts - /src/app/pages/admin-page/admin-page.component.ts - /src/app/pages/collaborate/collaborate.component.ts - /src/app/pages/explore/explore.component.ts - /src/app/pages/profile-page/profile-page.component.ts - /src/app/services/dialog-helper.service.ts - /src/app/services/progress-bar.service.ts - /src/app/services/query-action.service.ts - /src/app/services/snackbar.service.ts - /src/app/wizards/add-compilation/add-compilation-wizard.component.ts - /src/app/wizards/add-entity/add-entity-wizard.component.ts - /src/app/wizards/add-group-wizard/add-group-wizard.component.ts UPDATE package.json (2569 bytes) ✔ Packages installed successfully. Migration completed (1 file modified). !!!After running 'ng generate @angular/material:mdc-migration'!!! ** Executing migrations of package '@angular/material' ** ▸ Updates Angular Material to v17. ✓ Updated Angular Material to version 17 Migration completed (No changes made). * Broken state, but compiles, with the following changes: - downgraded bson to 4.7.2 - moved from angular "browser"-builder to "application"-builder - used newer syntax to define angular material theme - adjusted some style imports * Update to Angular 17.3, migrate to standalone components & new control flow syntax * Run Control Flow Migration: `ng g @angular/core:control-flow` * Run Standalone Migration: `ng generate @angular/core:standalone` * Update `tsconfig.json` and `angular.json` to match more closely to Angular 17 examples * Update browserlist and move it to `package.json` * Remove `src/common` folder and instead include `kompakkt-common` as a github dependency * Compiling, but broken Angular Material * Fix Angular Material Styles * Fix AM Styles Part 2 - Add fixes for Angular Material issues with explore entity/compilation styles - Delete own comments * Style Changes #40 - remove the history button from the filter options in kompakkt and add it to the navigation bar like in semantic kompakkt --> VE: Removed login and registration button from actionbar, removed actionbar from home-page - add the New Object and for now for kompakkt also the New Collections button to the navigation bar - change the fontsize from the button to 14 - if possible change also the search options to font size 14 - in semantic kompakkt it also says "Search for objects and compilations", but we don't have the "compilations" here, only in kompakkt, so better write here "Search in objects" and in kompakkt better "Search in objects and collections" (or depending from the toggle function of the Objects and Collections) - align the search options with the logo at the navigation bar - gap between buttons, history button and "Profile"/"Logout": 8px * UI Design #40 Object options: - make sure the icons are size 24x24 - font: Open Sans, size: 14 - trash bin color: E91E63 - the title of the object should also be the same font and font size. Fix licence size * UI Design #40 Login and Register - Remove Login and Register from actiobar - The font for the "Cancel" and "Create new account" is wrong, change it to Open Sans - The "Cancel" button is orange, it should be pink: E91E63. - Same with the accent color of the input fields - Colors in Login-Dialog * UI Design: object view bar #40 - gap between the icons: 16px, the rest stays 8px. - Since we changed the navigation bar, the "History", "New Object" and "New Collection" button can be removed here. - Move everything to the right to make it the same like in semantic kompakkt. - change the color to blue for the "Annotate" and the "Publish" button. Colorcode: 00AFE7 - make sure the font of the buttons is Open Sans and size 14px. - We are using an "Annotate" button in semantic kompakkt, so replace the Annotate icon with the button. - The three icons under the picture description also are integrated in the option bar now to make it similar to semantic kompakkt. - Align the navigation bar and the option bar (both with 24px gap from the right) * UI Design: Upload Process + Object view Upload Process: - Change the color of the "Reset" button here in kompakkt to the pink color, right font for whole overlay - fix text in finalize-settings Object view: - icon for collection-choice - nested menu for existing collections * Change text of actionbar * Update Visibility Settings First changes from #40 * Update Metadata next to object - update licence view - update persons and institutions regarding issue #42 * Update Metadata - change Ui from akkordeon to sidenav (like in semantik-kompakkt) - change first style issues with the new sidenav-content * Update meta-data * Update Metadata (related agents) * Finish related persons and institutions * Fix bug when removing persons or institutions * Update metadata (creation) WIP * Update metadata - add creation - add links - add additional component for agents - update entity-Component * Update Metadata - add link-component in new format - add biblioRef-Component iu new format * Update metadata - add physical object to metadata-form - extract general information in separate component * Update agents - add searchfunktionality for prename and name - add funktionality for updating existing users - fix style issues in agent-card * Update agents & creation agents: - add tabs for persons and institutions - add translations for agent-forms creation: - update creation card output --> show every tuple together - update creation(card) style * Update metadata - extract externalids - extract dimensions - update biblioRef output - extract general * Update General - extract general information in separate component - fix issues in autocomplete of tags --> selecting tag and adding tag at the same time, it was possible to add empty tags, input-value was not empty after selecting or adding a new tag * Update physicalEntity - add necessary forms for physical entity - update agent-form to save agents in physicalEntity - update general-form to save and output correct values - delete code-validation for place * Update Metadata - update output for all metadata - physicalEntity is set now - everything will be saved in the digitalEntity - extract list of roles in component --> output of agents is now in the list-component * Small fixes - dialog when closing edit-entity-window - change text in add-entity-window when there is no back just cancel - set required fields for digitalEntity and physicalEntity - delete unneccassery code - set colored headline for invalid physical object - update validation for physical object * Update agents - fix issue when setting agents to update --> form in physical object will not be set * Update agents - fix issue when changing tabs * Update metadata - extract card data of optional data in global component - adding a pipe for key mapping of objects * Minor Updates - Rename sentences when not in the right format - highlight active metadata-tab - fix small visual issues * Update metadata - update translation files to right format - update style issues in agents, dimensions, externalIds, biblio reference, metadata and physical object - change creation date in material-component datepicker - setup edit-mode on biblio reference - setup different card options for dimensions and biblio reference - add service for metadata communication between different components * Fix display issues * Update entity-settings-dialog.component.scss * Update entity-settings-dialog.component.scss * Pull request changes - replace *ngIf with @if and *ngFor with @for (only in the metadata) - merge agent-communication.service in metadata-communication.service and delete it (maybe there is another place, but I didn't find an apropriate yet) - delete unneccassary code - delete objects-Method and take valuePairPipe from angular instead (maybe custom pipe could be deleted but don't know how exactly) - add correct typings * Remove MapKeyPipe in favor of @if/@else inside of HTML template * Set Observables as properties instead of getters in AgentListComponent --------- Co-authored-by: Kai Niebes <[email protected]>
Metadata next to the object
I noticed that the information for the object view are very different in kompakkt and sk. In terms of what kind of information you can see and especially the “Persons and Institutions”/“Related agents” section. This issue is to discuss and decide which information is important here and how we decide to make it consistent in kompakkt and sk?
sk right now:


kompakkt right now:
“Related agents” sk:


“Persons and Institutions” kompakkt:
@lozanaross @ZetOE
The text was updated successfully, but these errors were encountered: