-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer Annotation cards #50
Comments
Thanks @Grizzly127 - this looks good in general. Two questions:
|
Thank you for the feedback @lozanaross Questions:
The new window: I also added the icons to the annotation list on the left
I changed the Infobox to @HeyItsBATMAN suggestion. Like that we can use the box more universal, maybe also as a "Warning" or "Important" box if we need that somewhere. ![]() |
Thanks @Grizzly127. I have a few further comments:
This I don't fully understand what you mean here. Delete button in SK means deleting annotation also in WB. Not sure what it does in Kompakkt, but it should be a real delete button maybe, so users can permanently delete the annotation?
Hm, ok, that's a useful function, but maybe should not be save icon, but rather the download icon? And don't we still need a save icon to 'save' after a user edits something? I gather maybe we're autosaving anyway, but sometimes users need a the visual security of a save button purely for cosmetic reasons, so they feel 'safe' even if the tool doesn't need them to click anything technically. This is also a Q for @HeyItsBATMAN Regarding the expanding icon - I think I prefer the one we use in SK - it's a bit obscure but it functions both ways - making window smaller or bigger. The expanding icon you selected would need flipping once the window is bigger, to indicate possibility to make it smaller again. I also agree there is an issue with having too many icons duplicated in both main annotation window and in sidebar. In sidebar we should maybe have the full range of options:
In annotation window we could then have only (mode 1):
Once users click the edit button, we need to provide I think a slightly different set (mode 2):
If they click save, then we revert back to the mode 1 above. I wonder if visibility toggle is needed in the annotation windows? I feel like maybe it's enough if it's only in the sidebar. Let me know what you think re. all the above suggestions. |
Agree, this icon should be swapped.
"Closing" the edit mode autosaves changes to annotations, as well as reordering them by dragging and dropping saves the changed order. However, there could probably be a global indicator, always visible when annotating or changing settings, to indicate saving progress. There are some Cloud Icons in Material Icons, and Figma uses a cloud to indicate saving progress as well, but we can choose whatever we want as long as it's a better indicator to the users. |
Dear @Grizzly127 & @HeyItsBATMAN - thanks for above comments. Regarding autosaving @Grizzly127 can you mockup something that indicates (globally) to users when autosaving has completed... maybe a small popup banner in the top or bottom that pops up discretely and moves out of view when autosave is complete. It can be text with some kind of icon (cloud icon?) indeed. Regarding the preview button - aha, yes better to use the eye here for visibility - what's the preview icon that we can use in explore page? Regarding delete - I think for consistency, it's better not to have a dropdown menu under edit icon, but simple click that opens the edit view and then delete has it's own icon, as mocked up above. I would also like to see how adding media works, so please post a mockup here when that's decided. Thanks! |
Sidebar design and edit annotation window:
Edit annotation window
|
Thanks @Grizzly127 - the sidebar design looks quite good, I just have a few questions:
|
@Grizzly127 I am not sure about the design of the Edit Annotation window. What is the need to see the preview next to the editing window? It takes up a lot of space without providing much new information. I think the way the preview was a switch (with the eye icon) was a bit better before. And the bigger the edit window in Kompakkt is, it means it will get even bigger in SK where we have more options. Adding grey boxes within a larger white box is also a bit of a strange design pattern that I don't think we've used elsewhere. I would suggest we use the SK window as a guide and just make a more minimal version for Kompakkt that doesn't have author, license, and related concepts. |
@Grizzly127 I see here you also have the boxes within boxes in the annotation sidebar, but those are also unnecessary, the way you had the design earlier looked fine, with thin dividing lines. The only thing you can do to make the lines look more elegant is to run them edge to edge, so don't give them padding, just run them straight through the entire sidebar, this will be more in line with how lines are used in other parts of the UI - think about navigation and action bars, metadata on the side of the viewer window, etc. |
Edit annotation windowHere is one version with tabs to see the preview, this is an example for kompakkt, where you can embed media. Here is one version with icons to see the preview or continue editing, this is an example for semantic kompakkt with more options. |
The idea was that it appears always when you open the annotations as a note, but to have more space, the user can close it.
Yes, I can change the text.
It is for downloading all annotation at once. |
@Grizzly127 Great - love the tabs, let's go with that. Just not sure about the delete icon - what is it supposed to delete? For me it would make sense to be able to delete the embedded media after it's been added, but that can work similar to how the metadata wizard has a red x mark to delete something added. If it's an icon to delete the whole annotation, it probably makes more sense to either live only in the sidebar as an icon, or to be a button next to cancel / save: e.g. cancel / delete / save, and delete is outlined like cancel. For the embedded media - we should bring this back in SK, too actually, but I would suggest not having two styles of text there, but rather only "Embed media URL" and then "Fallback description" next to it. And I now think maybe we don't need so many add buttons - perhaps it's just one in the end - if you look at the metadata wizard, the creation data can be added all in one go. The Wikibase fields in SK should all be not text entry fields, though, but rather the search fields with magnifier icon, like in the metadata wizard. Description author and license should be directly underneath the description I think, it doesn't make sense to separate them, then we can have a separator line, and then "Embed media", "Add related media", "Add related concepts" below. So maybe we have Add button only in 2 places below license and below related concepts, and the whole dialog window has two main sections - top one around the description, and bottom one focused on the related bits. |
@Grizzly127 OK
Hm, I wonder if maybe we should make this more clear, like "Download all annotations [icon]" - spell it out, otherwise it's possibly confusing. |
I think there is also some information, that it is downloaded in json-format. Do we need to add this information? |
@lozanaross Here I implemented the comments for the semantic kompakkt annotation editor: |
Yes, button is nicest I think, just need to think is it a fully rounded button (like a pill as you've mocked it up), or a rectangular button with rounded edges, if you look at the settings sidebar, i think you use the rectangular buttons more... but what is the difference... do we have a logical division when we use which type of button?
This we can skip i think, because all download buttons deliver json, so they'll get it if they try it once. |
@Grizzly127, regarding the designs of the expanded annotation dialog:
All looks great, just see my comment here: https://gitlab.com/nfdi4culture/ta1-data-enrichment/semantic-kompakkt/-/work_items/121#note_2032680383 We can apply these rules here, and you can in fact also see the expandable edge of the text field (marked by the two diagonal lines) here in Github comments, too. |
@lozanaross |
I added the designs for semantic-kompakkt in gitlab (https://gitlab.com/nfdi4culture/ta1-data-enrichment/semantic-kompakkt/-/work_items/121#note_2033132532) |
@Grizzly127 Looks great, thanks, all makes sense. Regarding the small lines that act as toggle, don't worry, that's a standard element in the frontend framework, so can be used out of the box. |
Viewer annotation allWe changed "Content" to "Annotation body" in semantic kompakkt, therefore also here in kompakkt the changes: and here is one mockup of everything together:
![]() ![]() |
@Grizzly127, comments below:
Great.
By 'extend window' do you mean the icon that opens 'preview'? I think it actually doesn't make much sense anymore due to various other redesigns of the main edit window. If you mean this icon:
I noticed something else now, when I start making a new annotation, the first thing I get is this one: But this is not very useful because I can't do anything there and should immediate press edit. Why don't we immediately open the Edit view when a user starts a new annotation? @HeyItsBATMAN @ZetOE Also looks like the delete & edit button are reversed, i think edit should come first.
Cancel is enough I think. |
Yes I mean this icon. It was not for preview, but for extending the window and having a bigger/smaller one if there is more text for example.
@lozanaross Good idea, I think this makes the most sense for the user. |
Viewer Design
Here are suggestions for the viewer side bar and the viewer cards:
Here you can see the sidebar where the annotations are listed. On top there is an infobox about the default annotations, then you can see the preview for the first annotation, the title and the annotation itself (here only a description for the first annotation). The annotations are separated with a grey line.

The card for the annotations could look like this:

Either only text or text and media.
You have icons to make the annotation bigger. That could look like here for example. The background could become more transparent or darker then.

And you have an icon to edit or delete an annotation.



Delete:
Edit:
Here we should discuss how exactly media is embedded. With a link? How to add several media types?
@HeyItsBATMAN @ZetOE @lozanaross
The text was updated successfully, but these errors were encountered: