Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non leader instances enable readiness probe to align with other operators #1090

Open
1 task
randmonkey opened this issue Jan 24, 2025 · 0 comments
Open
1 task
Labels
area/feature New feature or request
Milestone

Comments

@randmonkey
Copy link
Contributor

Problem Statement

Non-leader instances returns false on readiness probes. If a deployment has multiple instances, it can never be seen as "ready" in some CI/CD systems (like ArgoCD) . Since the validation webhook is migrated to CELs in KGO 1.5, there are no exposed services that requires the traffic to be only sent to the leader, we can enable the readiness probed of non-leader instances.

Proposed Solution

Start the readiness probe service on both leader and non-leader instances.
...

Additional Information

...

Acceptance Criteria

  • Leader and non-leader instances are all in ready state after started
@randmonkey randmonkey added the area/feature New feature or request label Jan 24, 2025
@randmonkey randmonkey added this to the KGO v1.5.x milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant