Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Sort the token by the balance on mobile app #1234

Open
4 tasks done
Sokol142196 opened this issue Dec 12, 2023 · 8 comments · Fixed by #1480 · May be fixed by #1495
Open
4 tasks done

Mobile - Sort the token by the balance on mobile app #1234

Sokol142196 opened this issue Dec 12, 2023 · 8 comments · Fixed by #1480 · May be fixed by #1495
Assignees
Milestone

Comments

@Sokol142196
Copy link

Sokol142196 commented Dec 12, 2023

Describe the task

  • Show the balance on the right

Image

  • Sort the token by the balance on the Select token when performing actions:
    • Send fund
    • Staking
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Dec 19, 2023

Version test: PR #1253 18:27 16/12/2023
Device test: IP 11

@Quangdm-cdm Please re-check this issue

  • Re-check sorting by Select token when receive
  • Auto sorting list token
Issue1234.MP4
  • Auto select token when staking
    Steps:
  1. Go to Staking screen
  2. Touch select token
  3. Open the displayed screen

Actual: Back to staking screen and auto select token

@Sokol142196
Copy link
Author

Sokol142196 commented Dec 25, 2023

Version test: Pr 1253 09:55 20/12/2023

Please check the issues:

  • Do not show the balance of the token have no $balance (have no price and custom token)
    • Example: Native token (HDX, TUR...), Custom token (MFG - Moonbase Alpha, PANX - Aleph Zero Testnet)
RPReplay_Final1703480692.MP4
  • Automatically change token when switching tab pool and nominate on the fisrt time
    • Actual: For example, automatically switch from KSM to ASTR
RPReplay_Final1703489579.MP4
  • Expect:
    • If the token supports both types -> keep the token
    • If the token supports only 1 type -> Show the first item found

Need to discuss:

  • Show the balance in cases:

    • Balance = 0
    • Do not get balance (network is off or can't connect RPC)
  • Token default on Send and Staking screen

@haiyenvu23
Copy link

haiyenvu23 commented Feb 5, 2024

Version test : PR #1253 01/23/2024 10:45 AM
Device test : IP 6S
Validation passed in case :

  • Show the balance on the right
  • Sort the token by the balance on the Select token when performing actions : Send fund
  • Re-check sorting by Select token when receive, auto sorting list token
  • Do not show the balance of the token have no $balance (have no price and custom token)

Please check the issues:

  • Do not show the balance of the token when click Send on token name screen
RPReplay_Final1707103435.mov

@haiyenvu23
Copy link

Version test : PR #1253 02/05/2024 2:45 PM
Device test : IP 6S
Validation passed

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Feb 16, 2024

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-312-1253-merge-2024-02-05T07-44-51.ipa
Device test: IP 11

  • Show incorrect token in case network is turn off
    Actual: Balance = 0
    Image
    Expect: Nothing displayed

@Quangdm-cdm Quangdm-cdm linked a pull request Feb 19, 2024 that will close this issue
@Sokol142196 Sokol142196 changed the title Sort the token by the balance on mobile app Mobile - Sort the token by the balance on mobile app Feb 20, 2024
@haiyenvu23
Copy link

haiyenvu23 commented Feb 20, 2024

Version test :

Validation passed in case :
When turn on network :

  • Show the balance of the token have $balance
  • Show the balance of the token have no $balance = 0

When turn off network :

  • Don't show the balance of the token
RPReplay_Final1708428511.mov

@Sokol142196
Copy link
Author

Temporarily revert the code to this section as it negatively affects the performance of the application
=> Re-open this issue then follow-up after handle performance

@Sokol142196 Sokol142196 reopened this Feb 26, 2024
@hieudd hieudd modified the milestones: Milestone 7, Milestone 8 Jun 27, 2024
@Sokol142196
Copy link
Author

Describe the bug

  • Re-check case sort token by balance

Actual:
Image

  • Expect: Sort by balance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment