Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sorting via a language #357

Closed
1 task done
davvarrr opened this issue Nov 2, 2023 · 16 comments
Closed
1 task done

Adding sorting via a language #357

davvarrr opened this issue Nov 2, 2023 · 16 comments
Assignees

Comments

@davvarrr
Copy link
Collaborator

davvarrr commented Nov 2, 2023

Describe your suggested feature

I think that adding sorting via a language would be relevant. I've made a prototype by adding "tags" in the recently added parser ( e788cff ) , but ideally we'd need a separate section to better manage this sorting.
This kind of addition could be applied to others like manga dex, which would be a big plus for searching for manga translated into the desired language.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
@Koitharu
Copy link
Member

Koitharu commented Nov 4, 2023

Do you mean adding new section "language" to filter?
Like "Sort order", "Language" and "Genres" (aka tags), right?

@davvarrr
Copy link
Collaborator Author

davvarrr commented Nov 4, 2023

yes, in this style, to be able to manage languages independently.
because adding them to tags isn't very clear.
Then we'll see if we can make an option to cumulate tags with or without mangadex, because in the case of mangadex you can do language + tag but not on other sources.

@davvarrr
Copy link
Collaborator Author

davvarrr commented Nov 12, 2023

@Koitharu I don't know if you're planning to add this feature, but in the same vein, you could also add statu share sorting.
all sources on the mangareader & madara template are compatible with a sort of this kind, so after adding this one, we'll be able to make a lot of sources compatible at once

@Koitharu Koitharu self-assigned this Nov 14, 2023
@Koitharu
Copy link
Member

@davvarrr how do you think, is it worth to add possibility to select multiple languages or just one? (I mean multiple like tags or single like sort order in current implementation).

And also I didn`t catch what do you mean by

add statu share sorting

@davvarrr
Copy link
Collaborator Author

Few people and few sites do multilingual sorting (I only know mengadex at the moment), so if there's only a single-language selection, it's not a problem.

@davvarrr
Copy link
Collaborator Author

For "add statu share sorting" its : Sorting by ongonig , canceled , paused and finished

@davvarrr
Copy link
Collaborator Author

@Koitharu
Copy link
Member

@davvarrr can you please take a look on #387 ?

@davvarrr
Copy link
Collaborator Author

Thanks for the addition ;)
I'll just need an example for languages and status so I can better understand how to implement them on compatible sources :)

@Koitharu
Copy link
Member

@davvarrr I plan to make a new release, can I merge branch filter into master?

@davvarrr
Copy link
Collaborator Author

No I think I'll do it this weekend

@davvarrr
Copy link
Collaborator Author

And had you planned the language filter in a little while to know if I could add it on weekends?

@Koitharu
Copy link
Member

Yes, language filter will be implemented soon, and it would be nice to have at least one source with it before

@davvarrr
Copy link
Collaborator Author

davvarrr commented Nov 29, 2023

You had the parser GalleryAdultsParser which has a prototype of language filter but the best is to test on mangadex it is quite simple to set up.

@davvarrr
Copy link
Collaborator Author

davvarrr commented Dec 5, 2023

@Koitharu I changed "originalLanguage" share "availableTranslatedLanguage" which is more relevant for a manga search.
Thanks for the examples, I'll look at them later this week or this weekend and add them to the sources that support it.

@davvarrr
Copy link
Collaborator Author

davvarrr commented Dec 8, 2023

@Koitharu Normally, all language-compatible sources are made. For bato, I added the languages manually, because too many languages are not used by the source even though it lists them.

@davvarrr davvarrr closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants