-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sorting via a language #357
Comments
Do you mean adding new section "language" to filter? |
yes, in this style, to be able to manage languages independently. |
@Koitharu I don't know if you're planning to add this feature, but in the same vein, you could also add statu share sorting. |
@davvarrr how do you think, is it worth to add possibility to select multiple languages or just one? (I mean multiple like tags or single like sort order in current implementation). And also I didn`t catch what do you mean by
|
Few people and few sites do multilingual sorting (I only know mengadex at the moment), so if there's only a single-language selection, it's not a problem. |
For "add statu share sorting" its : Sorting by ongonig , canceled , paused and finished |
I've added an example on madara if that helps. : https://github.com/KotatsuApp/kotatsu-parsers/blob/6f73ff23e874759a8c955ab06f39cf207a26492b/src/main/kotlin/org/koitharu/kotatsu/parsers/site/madara/MadaraParser.kt#L174C2-L174C2 |
Thanks for the addition ;) |
@davvarrr I plan to make a new release, can I merge branch |
No I think I'll do it this weekend |
And had you planned the language filter in a little while to know if I could add it on weekends? |
Yes, language filter will be implemented soon, and it would be nice to have at least one source with it before |
You had the parser GalleryAdultsParser which has a prototype of language filter but the best is to test on mangadex it is quite simple to set up. |
@Koitharu I changed "originalLanguage" share "availableTranslatedLanguage" which is more relevant for a manga search. |
@Koitharu Normally, all language-compatible sources are made. For bato, I added the languages manually, because too many languages are not used by the source even though it lists them. |
Describe your suggested feature
I think that adding sorting via a language would be relevant. I've made a prototype by adding "tags" in the recently added parser ( e788cff ) , but ideally we'd need a separate section to better manage this sorting.
This kind of addition could be applied to others like manga dex, which would be a big plus for searching for manga translated into the desired language.
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: