Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG text paint-order = "stroke" is not supported #218

Open
aziesemer opened this issue Nov 15, 2018 · 4 comments
Open

SVG text paint-order = "stroke" is not supported #218

aziesemer opened this issue Nov 15, 2018 · 4 comments

Comments

@aziesemer
Copy link
Contributor

aziesemer commented Nov 15, 2018

If you try this code:

<svg id="floor2" class="floor" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="-33250 -7500 800 250">
<style type="text/css">.ruler-text.metric{fill:#000; font:107pt arial; text-anchor:middle; alignment-baseline:middle; paint-order: stroke; stroke: #ff0; stroke-width: 10pt; stroke-linecap: butt; stroke-linejoin: miter}</style>
<text transform="translate(-32852.4 -7353.87) rotate(0)" class="ruler-text metric">2.66m</text>
</svg>

You'll end up with:
screen shot 2018-11-15 at 9 54 34 am
instead of:
screen shot 2018-11-15 at 9 55 51 am

PR #217 fixes that.

@liZe
Copy link
Member

liZe commented Nov 26, 2018

paint-order has been added in SVG 2.0 and CairoSVG doesn't have a clear plan to support this new version 😄. By the way, this change seems harmless and there's no reason not to include it. Thank you!

@liZe
Copy link
Member

liZe commented Nov 26, 2018

Oh, I didn't realize that #217 and #218 were conflicting. I have to check this.

@aziesemer
Copy link
Contributor Author

aziesemer commented Nov 26, 2018

@liZe Yes, I have it merged in my computer but had to split in order to produce 2 different PRs.

@aziesemer
Copy link
Contributor Author

@liZe I fixed the conflict in the same PR and it should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants