Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS smacof n_jobs argument #112

Open
choltz95 opened this issue Mar 3, 2022 · 1 comment
Open

MDS smacof n_jobs argument #112

choltz95 opened this issue Mar 3, 2022 · 1 comment
Labels

Comments

@choltz95
Copy link

choltz95 commented Mar 3, 2022

Hi- I just noticed that even though embed_mds accepts an n_jobs argument, it never gets passed to the smacof wrapper ~defaulting to 1 each time.

Is that a problem? Btw, unrelated, but sklearn also has a parallel pdist which also takes an n_jobs argument.

@choltz95 choltz95 added the bug label Mar 3, 2022
@scottgigante
Copy link
Collaborator

@choltz95 this is likely an oversight. It shouldn't be terribly impactful assuming you are using n_landmark=2000 but worth fixing nonetheless. I am no longer an admin on this repo but I'd encourage you to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants