Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more search engines and even merge with duckduckgpt? #18

Open
PeterDaveHello opened this issue Oct 15, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@PeterDaveHello
Copy link
Contributor

Hello, I just get started to try this browser plug-in, also trying to contribute (#16, #17), and I found https://github.com/KudoAI/duckduckgpt, it looks like there may be a lot function/code base can be shared between this two projects, which save the developer and contributor a lot of effort to enhance the feature, so just wondering would you consider to just merge them, and more search engines support can be added? Thanks!

@adamlui
Copy link
Member

adamlui commented Oct 15, 2023

Hey @PeterDaveHello indeed the codebase are near identical, which search engines would you like supported? Also it does not take me much effort to sync code between the scripts btw (and I enjoy it actually)

@PeterDaveHello
Copy link
Contributor Author

Maybe Google, StartPage, Bing, Kagi, etc.? Though the effort to sync code base could be acceptable right now, once, you got more contribution and feature, it'll become much higher, and even for the users, simply install one would be better, especially there are some configs can be shared, right?

@adamlui
Copy link
Member

adamlui commented Oct 15, 2023

@PeterDaveHello I am working on a Google one that I will publish once I implement a new feature (which will also be applied to DDGPT and BraveGPT). The sync code can always be automated when there's too many. A user in the past posted on DuckDuckGo forum they prefer the singular approach because the code would get larger and larger as more custom logic or CSS is added. But one is also useful for those who prefer that way, so I'm thinking of doing one for many AND continue to make singular ones

@adamlui adamlui added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants