From d34e6a7b1cd4bf5b044b274ec5ddd80b7b24cfc8 Mon Sep 17 00:00:00 2001
From: Zaprit <zaprit@hugespaceship.io>
Date: Sun, 20 Oct 2024 17:32:04 +0100
Subject: [PATCH] Fix code review suggestions

---
 .../Controllers/Login/LoginController.cs             | 12 +++++++++---
 .../Configuration/ServerConfiguration.cs             |  2 +-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs b/ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
index 43fe553e4..082a560ea 100644
--- a/ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
+++ b/ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
@@ -17,8 +17,14 @@ namespace LBPUnion.ProjectLighthouse.Servers.GameServer.Controllers.Login;
 [ApiController]
 [Route("LITTLEBIGPLANETPS3_XML/login")]
 [Produces("text/xml")]
-public class LoginController(DatabaseContext database) : ControllerBase
+public class LoginController : ControllerBase
 {
+    private readonly DatabaseContext database;
+    public LoginController(DatabaseContext database)
+    {
+        this.database = database;
+    }
+    
     [HttpPost]
     public async Task<IActionResult> Login()
     {
@@ -51,13 +57,13 @@ public async Task<IActionResult> Login()
 
         string username = npTicket.Username;
 
-        if (String.IsNullOrEmpty(username))
+        if (string.IsNullOrEmpty(username))
         {
             Logger.Warn("Unable to determine username, rejecting login", LogArea.Login);
             return this.Forbid();
         }
 
-        await database.RemoveExpiredTokens();
+        await this.database.RemoveExpiredTokens();
 
         UserEntity? user;
 
diff --git a/ProjectLighthouse/Configuration/ServerConfiguration.cs b/ProjectLighthouse/Configuration/ServerConfiguration.cs
index 30c7c89be..ba9f7f4a1 100644
--- a/ProjectLighthouse/Configuration/ServerConfiguration.cs
+++ b/ProjectLighthouse/Configuration/ServerConfiguration.cs
@@ -11,7 +11,7 @@ public class ServerConfiguration : ConfigurationBase<ServerConfiguration>
     // This is so Lighthouse can properly identify outdated configurations and update them with newer settings accordingly.
     // If you are modifying anything here, this value MUST be incremented.
     // Thanks for listening~
-    public override int ConfigVersion { get; set; } = 26;
+    public override int ConfigVersion { get; set; } = 27;
 
     public override string ConfigName { get; set; } = "lighthouse.yml";
     public string WebsiteListenUrl { get; set; } = "http://localhost:10060";