Allow any site

[zemogle]

API only currently allows for LCOGT sites to be specified by 3-letter airport code. Extend this API so latitude and longitude can be used instead.

[freerobby]

@zemogle I'm considering adding this functionality so that I can integrate whatsup into AstroSwarm. Do you have any opinion on what the API call should be for an arbitrary-location search? Google uses a location=<latitude,longitude> parameter. I was thinking of using the same, and then requiring one of [site,location] to be supplied to the existing search call.

[zemogle]

I was thinking of using lat=xx&long=yy. Are you thinking of using WhatsUP as a service or using your own install of it?

[benburleson]

Hi Edward! I'd be wary of using `long`, as it's a reserved word in some languages. Hope all is well! -Ben

…

On Tue, Oct 17, 2017 at 6:34 AM, Edward Gomez ***@***.***> wrote: I was thinking of using lat=xx&long=yy. Are you thinking of using WhatsUP as a service or using your own install of it? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADLz_x51ygNJOqp1r0xgt5ddpwHmN1kks5stK0AgaJpZM4E_6ke> .

[zemogle]

Hi Ben! Great to hear from you. Thanks for the reminder about long. I think lon and lat should be fine.

[talister]

On Oct 17, 2017 08:39, "Edward Gomez" <[email protected]> wrote: Hi Ben! Great to hear from you. Thanks for the reminder about long. I think lon and lat should be fine. Could also 'elong' (East longitude) to make it explicit which direction is positive. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABsafAJmq6C0F2c_0bYJirtcW9i_OuF4ks5stLwZgaJpZM4E_6ke> .

[freerobby]

@zemogle Thanks for the guidance. I have a POC here using lat and lon params: https://github.com/LCOGT/whatsup/compare/master...astroswarm:rg-custom-locations?expand=1

I infer from the code that you are only running via Docker in production. I'm planning to write a docker-compose config to run everything locally through Docker (including MySQL). Does this seem like a reasonable development approach to you, or is there another I should use?

Is whatsup/fixtures/full_catalogue.json your current source of truth for your production endpoint, or is that data set maintained elsewhere? If the latest data is open source, I'd love to pull it in and self-host!

[freerobby]

n.b. Above-comment edited to reflect latest information.

I'm close to having this working, but could use feedback on a couple things:

1. I noticed that the data import is broken. full_catalogue.json contains columns that have since been deleted. I edited full_catalogue.json to comply with the latest database schema (removed "exposure" and "filters" columns on "Target" objects), so that importing now works. However, I suspect this json file is out of date. I'd love to wire this up to the latest data set rather than the version I modified. Is the latest data set publicly available somewhere?

2. I built a docker-compose workflow to launch, migrate, and seed a database and then run the application, all with one command. It's all documented in a ./development directory. Feedback here much appreciated. I'm not wedded to this way of doing things, but I found it the easiest way to get everything up and running in a repeatable fashion.