Skip to content
This repository has been archived by the owner on Feb 13, 2021. It is now read-only.

Create SHACL for Attribution Pattern #36

Open
sfolsom opened this issue Apr 17, 2018 · 8 comments
Open

Create SHACL for Attribution Pattern #36

sfolsom opened this issue Apr 17, 2018 · 8 comments

Comments

@sfolsom
Copy link
Contributor

sfolsom commented Apr 17, 2018

Once the conversation on Contribution vs. Activities is settled, create Attribution SHACL. https://github.com/LD4P/ArtFrame-RareMat/blob/develop/modeling_recommendations/attributions.md

@rjyounes
Copy link
Contributor

rjyounes commented May 4, 2018

This was developed by the Art group, so I'm not sure we need to implement it. What does @jak473 think?

@rjyounes
Copy link
Contributor

Melanie may have already done this for the art SHACL. If so, we can borrow it.

@melanieWacker
Copy link
Contributor

No, not yet -- I'll do it asap

@rjyounes rjyounes added the art label May 14, 2018
@melanieWacker
Copy link
Contributor

Added attribution pattern to art form SHACL. Please check.

@rjyounes
Copy link
Contributor

The property shape looks good. Then you need an AttributionForm, correct?

@melanieWacker
Copy link
Contributor

Correct. I added that into the same file.

@rjyounes
Copy link
Contributor

Sorry, I missed it somehow.

It looks perfect. I would however remove these assertions:

rdf:type rdfs:Class ;

SHACL uses this to mean that the node shape is also a class, that is then automatically its own target class (if you then define another targetClass I think you'd have invalid SHACL, but not 100% sure). We don't want to use form shapes as target classes, so best to leave that out. I think they were in Steven's original SHACL because TopBraid was generating them.

@melanieWacker
Copy link
Contributor

Thanks! Will take those out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants