Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to support sigma_sq optimization in PyTorch #112

Open
alecmdunton opened this issue Mar 28, 2023 · 1 comment
Open

Need to support sigma_sq optimization in PyTorch #112

alecmdunton opened this issue Mar 28, 2023 · 1 comment
Assignees
@alecmdunton

Comments

@alecmdunton
Copy link
Collaborator

alecmdunton commented Mar 28, 2023 •
edited
Loading

Torch doesn't like it when we try to use, e.g., muygps_sigma_sq_optim on a MuyGPS object because of an issue with deepcopy. Will need to figure out a way to support computation of sigma_sq in MuyGPyS.torch.muygps_layer that doesn't require calling anything in MuyGPyS._src.
@alecmdunton alecmdunton self-assigned this Mar 28, 2023
@bwpriest
Copy link
Member

This is still an issue, and needs to get addressed. I believe that we need to stop treating MuyGPS objects as immutable and stop treating optimization functions as pure functions, but this might be confusing to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecmdunton alecmdunton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwpriest @alecmdunton