Easier initial guess for acceleration in dynamics. #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btalamini
approved these changes
Sep 11, 2024
src/serac/numerics/odes.cpp
Outdated
| d2u_dt2 = state_.d2u_dt2; | ||
| d2u_dt2.SetSubVector(constrained_dofs, 0.0); | ||
| d2U_dt2_.SetSubVectorComplement(constrained_dofs, 0.0); | ||
| // d2U_dt2_.SetSubVectorComplement(constrained_dofs, 0.0); |
There was a problem hiding this comment.
Looks good. Why not remove the commented line?
tupek2
force-pushed
the
tupek/initial_acceleration
branch
from
7b878f2
to
a1c8455
Compare
tupek2
force-pushed
the
tupek/initial_acceleration
branch
from
a1c8455
to
67b54f6
Compare
tupek2
commented
Sep 27, 2024
tests
Outdated
There was a problem hiding this comment.
@chapman39 Is there a reason why these tests need to be in a submodule? I find it nice to always have code and tests update together in the same repo, when possible. Also, I have no idea if I even did this submodule thing correctly.
There was a problem hiding this comment.
The tests are in a submodule so that if the repo gets large with all the data that builds up, it can be cleaned out w/o having to alter the history of the serac repo. This has happened on all simulation codes I've been on
|
/style |
tupek2
force-pushed
the
tupek/initial_acceleration
branch
from
d2274fe
to
af5edb5
Compare
|
/style |
samuelpmishLLNL
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the initial acceleration guess results in element inversion. This change defaults the guess to 0.0, which is more robust in a challenging problem, but could potentially be slower for some kinds of problems.