Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow better customization of Caliper "configurations"/ options #1246

Open
chapman39 opened this issue Oct 9, 2024 · 0 comments
Open

Allow better customization of Caliper "configurations"/ options #1246

chapman39 opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
testing Related to testing

Comments

@chapman39
Copy link
Contributor

Adding extra options to Caliper besides the default has some support but there isn't really a way to utilize it using the Serac initialize function. Allowing extra Caliper options would help when we want to test MPI in more depth as well as HIP and CUDA. I haven't tested other Caliper options very much yet, but you can see them here. We could alternatively do something like Axom. This is the current situation:

// Serac Init
std::pair<int, int> initialize(int argc, char* argv[], MPI_Comm comm)
{
  ...
  // Start the profiler (no-op if not enabled)
  profiling::initialize(comm); // <-- this call should include the "options" argument, seen below
  ...
}

// Caliper Init
void initialize([[maybe_unused]] MPI_Comm comm, [[maybe_unused]] std::string options)
{
  ...
#ifdef SERAC_USE_CALIPER
  // Initialize Caliper
  mgr               = cali::ConfigManager();
  auto check_result = mgr->check(options.c_str());

  if (check_result.empty()) {
    mgr->add(options.c_str());
  } else {
    SLIC_WARNING_ROOT("Caliper options invalid, ignoring: " << check_result);
  }

  // Defaults, should probably always be enabled
  mgr->add("runtime-report,spot");
  mgr->start();
  ...
@chapman39 chapman39 added the testing Related to testing label Oct 9, 2024
@chapman39 chapman39 self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to testing
Projects
None yet
Development

No branches or pull requests

1 participant