Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thermomechanics from Serac driver and remove default.lua #1253

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

white238
Copy link
Member

@white238 white238 commented Oct 25, 2024

Test PR: LLNL/serac_tests#24 (merged to main)

thermomechanics was not working in default.lua and after speaking to @btalamini this class needs to be fixed anyways. I found this input file named confusing and this should alleviate that.

I also removed the ability to use anything other than solid and heat_transfer separately in the driver.

Fixes #1250

@chapman39
Copy link
Contributor

should we also remove data/input_files/tests/thermal_solid/thermal_expansion.lua or fix that at some point in the future?

@white238
Copy link
Member Author

white238 commented Oct 25, 2024

This PR was aimed at unblocking a user to ran into this. We should have a followup discussion on what path to take to re-enable input files with thermomechanics and also traction. As well as the thermomechanics class can't handle differing order's between the solid and heat_transfer parts.

@white238
Copy link
Member Author

This PR was aimed at unblocking a user to ran into this. We should have a followup discussion on what path to take to re-enable input files with thermomechanics and also traction. As well as the thermomechanics class can't handle differing order's between the solid and heat_transfer parts.

Made an issue #1256

@white238 white238 merged commit 507f6c6 into develop Oct 28, 2024
2 checks passed
@white238 white238 deleted the bugfix/white238/fix_overeager_error_check branch October 28, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable/fix default.lua test cases
4 participants