Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA Azure Bugfix: Only convert CTest output to JUnit if testing is enabled #1263

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

chapman39
Copy link
Contributor

@chapman39 chapman39 commented Nov 6, 2024

Fixes #1262

@chapman39 chapman39 added bug Something isn't working CI Continuous Integration gpu GPU related labels Nov 6, 2024
@chapman39 chapman39 self-assigned this Nov 6, 2024
Copy link
Member

@white238 white238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around @chapman39 !

@white238
Copy link
Member

white238 commented Nov 6, 2024

Well it got rid of the error after the build... but the warning is still there under the test section and on the main page. =/

@white238
Copy link
Member

white238 commented Nov 6, 2024

We could drop an empty/fake Text.xml file to shut it up when tests aren't being run... or play around with some options here to see if it quiets it:

https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/publish-test-results-v2?view=azure-pipelines&tabs=trx%2Ctrxattachments%2Cyaml

@chapman39 chapman39 marked this pull request as draft November 6, 2024 01:59
@chapman39
Copy link
Contributor Author

Putting on draft for now till I resolve the remaining warning.

Also kind of funny we just barely have enough space for the cuda builds

Screenshot 2024-11-05 at 6 01 31 PM

@chapman39 chapman39 marked this pull request as ready for review November 7, 2024 21:57
@chapman39 chapman39 added the ready for review Ready for active inspection by reviewers label Nov 8, 2024
@chapman39 chapman39 merged commit 464de23 into develop Nov 8, 2024
2 checks passed
@chapman39 chapman39 deleted the bugfix/chapman39/cuda-azure branch November 8, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration gpu GPU related ready for review Ready for active inspection by reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion to JUnit should not be running in CUDA Azure pipelines
3 participants