Extend range of supported notes in piano roll

[teeberg]

Reported in Discord: https://discordapp.com/channels/203559236729438208/332258319228207114?jump=395583597127532544

I'm looking to create a lightshow on a launchpad and some of the lights can't be lit due to the piano roll not going high enough to have a note corrosponding to that light.

[zonkmachine]

I think the range is moderated here.

void Note::setKey( const int key )
{
	const int k = qBound( 0, key, NumKeys - 1 );
	m_key = k;
}

[DeRobyJ]

The pianoroll has every possible note it can get from midi input...
You know, a midi note is described by 7 bits, so it can only go from 0 to 127...

What note number should the light get? How is it done by other software? Perhaps custom control change messages trigger by a "note"?

[zonkmachine]

You know, a midi note is described by 7 bits, so it can only go from 0 to 127...

Yes, but not in Note::Note() or Note::setKey() where qBound is used to limit the register.

Example:
const int NumKeys = NumOctaves * KeysPerOctave;

NumOctaves = 9
KeysPerOctave = 12

Note::setKey() max value is NumKeys - 1 which is ( ( 9 * 12 ) - 1 ) = 107.
The top 20 MIDI keys are set to 107. Note::Note is one higher so there you get 108.

[musikBear]

Looking for 'doables', but isent this one misunderstood?
In respect to audible notes, lmms is doing fine.
This very specific request is much better addressed with a new type of track -we could name it MIDICtrTCO a track where events are inserted as points, and where each point has a midi-output-value.
Infact -an automation-track, but only with points.
Like:

But how many users has this need? Is this usecase general enough to spend hours of implementation for?

[Spekular]

@he29-net, do you know if this is still relevant after #5868? I would assume it's fixed now, but don't want to close without knowing for sure.

[he29-net]

Yes, I believe this issue should be resolved in the recent alpha release, all 128 MIDI keys are now available.