Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join the repo with nodes #27

Open
dr-orlovsky opened this issue Dec 27, 2022 · 5 comments
Open

Join the repo with nodes #27

dr-orlovsky opened this issue Dec 27, 2022 · 5 comments

Comments

@dr-orlovsky
Copy link
Member

Both this repo and https://github.com/LNP-BP/nodes serve the same purpose. I think they can be joined into one repo (I will keep both commit histories, git allows that).

@nicbus @zoedberg @crisdut what do you think?

@crisdut
Copy link
Member

crisdut commented Dec 27, 2022

I agree with this.

I created a repo to running all nodes in regtest: https://github.com/crisdut/lnpbp-regtest

With this merge, i will maintain my repo only to experimental releases and use cases with wallets, LN, etc...

@zoedberg
Copy link
Member

Personally I don't think repositories are so similar (docker repo dockerizes also services that are not directly related to rgb) so I don't see reasons to merge them besides the benefit of having less repositories to maintain. But also I don't have reasons to object the merge so feel free to merge them if you think it's better.

@nicbus
Copy link
Member

nicbus commented Dec 28, 2022

as far as I see, both repositories try to make it easy to use RGB and related services, even though in a different way

I have no objection to merging the two of them

@dr-orlovsky
Copy link
Member Author

dr-orlovsky commented Dec 28, 2022

I put this proposal because lnpbp-nodes loose its sense of existing as a codebase (I failed to get multiple binaries compiled from dependencies with rust), but has a number of discussions wiki pages and docs. This repo hasn't them, but has some useful code (docker images)

@zoedberg BTW both repos are not related to just RGB and cover all LNP/BP nodes; docker just provides docker images for bitcoin & electrs, which are required by the nodes anyway.

So, merge of repos is not only about code (very few in both) but much more about issues/discussions.

@dr-orlovsky
Copy link
Member Author

More of the explanation why the nodes repo has to be deleted/archived if not merged with this one: LNP-BP/nodes#18 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants