fix: the format for comparison between RTCM packet preamble and current byte(#14) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbiefish
requested changes
Jun 24, 2022
| @@ -64,19 +64,22 @@ def parse(self, buffer): | |||
| rtcm_packets = [] | |||
| while index < len(combined_buffer): | |||
| # Find the start of the RTCM 3.2 packet | |||
| if combined_buffer[index] == _RTCM_3_2_PREAMBLE: | |||
| ascii_values = [] | |||
There was a problem hiding this comment.
For me the buffer still comes in as a byte array by default, and this causes the node to crash for me. so we should have some logic in here to handle both cases. Also I think that you could use the encode function instead of looping. I had success with the following implementation, but as I said, my buffer is already bytes, so please let me know if this works for you
if isinstance(combined_buffer, str):
ascii_values = combined_buffer.encode('utf-8')
elif isinstance(combined_buffer, bytes):
ascii_values = combined_buffer
else:
raise Exception('Buffer type is "{}" not a string or bytes, so we cannot parse it.'.format(type(combined_buffer)))Also I think a better name for ascii_values would be combined_buffer_bytes
|
Closing this for now. If this is a problem for anyone else feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mention in #14,
the parsed RTCM packets are empty, by debugging, in
rtcm_parser.pywe found thatcombined_buffer[index]is str but_RTCM_3_2_PREAMBLEis int which make this judgment unsuccessful.if combined_buffer[index] == _RTCM_3_2_PREAMBLE: