Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration parameters to activities #7

Open
Pirvu2k opened this issue Feb 28, 2021 · 0 comments
Open

Add configuration parameters to activities #7

Pirvu2k opened this issue Feb 28, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Pirvu2k
Copy link
Contributor

Pirvu2k commented Feb 28, 2021

Let the user customise the activities. For example, at the moment there is a fixed 10 second timeout on speed dating (for testing purposes only), but we should allow the user to set it to whatever value he wants. We could do this in 2 ways:

  1. Either include the configuration in the game command itself: !mitra game speed_dating 20 -> sets the round time to 20
  2. Or make a general-purpose map in the bot config for various properties: !mitra set speed_dating_time 20 -> sets the round time to 20

I think both approaches are good, but if we decide to implement the first one we need to find a smooth way to do it and reuse functionality as much as possible. Second one feels more natural but seems pretty general (the current config could appear when doing !mitra status )

@Pirvu2k Pirvu2k added the enhancement New feature or request label Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant