Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable client client grant for choreo app #257

Open
mefarazath opened this issue Jul 25, 2022 · 0 comments
Open

Disable client client grant for choreo app #257

mefarazath opened this issue Jul 25, 2022 · 0 comments
Milestone

Comments

@mefarazath
Copy link

Noticed that client_secret is added to config.json[1]. I am assuming this would be a dummy value.

In any case, it would be good to disable the client credentials grant type in the app that is used to exchange tokens at choreo sts.

This would potentially remove any possibility of misusing or exploiting the secret value.

Basically by removing credential grant type we make the secret not useful for anything other than token exchange.

[1]

"client_secret": "6SvfTHcnvIS1E52uSEsaxbTH4toa"

@nshamit nshamit added this to the MVP milestone Jul 30, 2022
@nshamit nshamit modified the milestones: MVP, Phase 2 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants