Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize options for sc_create.py #117

Closed
5 of 6 tasks
JoanneBogart opened this issue Aug 7, 2024 · 3 comments
Closed
5 of 6 tasks

Rationalize options for sc_create.py #117

JoanneBogart opened this issue Aug 7, 2024 · 3 comments

Comments

@JoanneBogart
Copy link
Collaborator

JoanneBogart commented Aug 7, 2024

Several changes should be considered:

  • Have a separate option for object type rather than no_galaxy, no_pointsource, sso. Value would be a list though for normal (non-debugging) calls it would have a single element
  • Have a separate option for files to be generated rather than no_flux and no_main. Value would be a list though mostly it would only have one element.
  • Instead of previous item, split creation into two scripts, one for main files and one for flux files.
  • Eliminate sed_subdir option. This is only used when writing out an instance catalog, a facility which is essentially broken
  • Add option star_truth so it is possible to use something other than default for value of star_input_format
  • Either rename galaxy_stride to just stride or add option star_stride
@JoanneBogart
Copy link
Collaborator Author

@jchiang87 do you have any comments about any of these? Is there anything more that belongs on this list?

@jchiang87
Copy link
Collaborator

As far as the options themselves are concerned, I don't have any additional comments. However, even though this is outside the scope of just changing the options, I'd recommend splitting the flux file generation off as an entirely separate application, since that really only depends on the main files, and I would think that most of the options would end up being irrelevant in this case.

@JoanneBogart
Copy link
Collaborator Author

Addressed by PR #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants