Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch images and cache them #13

Open
LauraAubin opened this issue Jul 31, 2019 · 1 comment
Open

Prefetch images and cache them #13

LauraAubin opened this issue Jul 31, 2019 · 1 comment
Labels
Feature This could be dope Medium Requires some thought

Comments

@LauraAubin
Copy link
Owner

LauraAubin commented Jul 31, 2019

I noticed that the first time an image is loaded it has a small delay. We could cache them the first time they are loaded so that this is not noticeable to the user.

Further more, we could implement prefetching for expected images. For example, we could prefetch the hover button once the quest is opened as it is very likely that the user will pause to read the quest, then interact with the buttons.

@LauraAubin LauraAubin added Medium Requires some thought Feature This could be dope labels Jul 31, 2019
@LauraAubin LauraAubin changed the title Load images at start and cache them Prefetch images and cache them Aug 2, 2019
@LauraAubin LauraAubin reopened this Aug 4, 2019
@LauraAubin
Copy link
Owner Author

LauraAubin commented Aug 4, 2019

Right now we are passing image urls to the image component to render the <img/> themselves. Instead, on mount we should create image objects for all urls so that they already exist and switching between them appears seamless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This could be dope Medium Requires some thought
Projects
None yet
Development

No branches or pull requests

1 participant