-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing block #289
Closed
Closed
Missing block #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tomas <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: supernovahs <[email protected]>
This PR fixes the CI by changing the docker setup action we were using for docker's official one
Co-authored-by: Tomas <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: supernovahs <[email protected]> Co-authored-by: supernovahs <[email protected]>
Closes Layr-Labs#182 --------- Co-authored-by: supernovahs <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: supernovahs <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: supernovahs <[email protected]>
This PR adds a GitHub release configuration, which should simplify changelog generation.
This PR introduces a changelog to the repository, ensuring clear documentation of changes, improvements, and updates across releases. By maintaining a changelog, we aim to: - **Improve Transparency**: Provide developers and users with a clear record of new features, fixes, and breaking changes. - **Enhance Collaboration**: Enable contributors to stay informed about the evolution of the codebase. - **Facilitate Communication**: Easily track progress and updates. ## Implementation - A `CHANGELOG.md` file has been added at the root of the repository. - The changelog format adheres to [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) guidelines, ensuring consistency and clarity. - Initial entries include the most recent version and its functionality. ## Proposed Workflow - All PRs introducing new features, fixes, or breaking changes should include a changelog update. - Use semantic versioning for tracking changes, with clear tags for **added**, **changed**, **deprecated**, **fixed**, and **removed** items. ## Future Steps - Update the contribution guidelines to include a section on maintaining the changelog.
Fixes # ### What Changed? This PR updates the changelog with a description of the latest changes. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? This PR fixes an oversight on the published changelog: a mention of the rewards-v2 changes updating the bindings. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? Runs `forge fmt` to format the contracts in `crates/contracts`. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes Layr-Labs#225 Layr-Labs#226 ### What Changed? This PR introduces a CI workflow that builds and formats the contracts in `crates/contracts`. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <[email protected]>
) Fixes Layr-Labs#234 This PR introduces the following changes * Adds a CI job to check if the anvil dump state is up to date. * Fixes the anvil's initial timestamp, otherwise the dump state will be different each time (since the timestamps are included in the state). * Updates the anvil dump state. The CI job works by generating a new anvil state and comparing it against the existing one using the `diff` command. If the new anvil state is different it means the existing one is outdated and therefore the CI will fail. **Note:** before performing the comparison between the existing and the new state, both files are sorted since the JSON format does preserve item order. - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
### What Changed? This PR changes the `make bindings` target to remove the existing bindings before generating the new ones. This is important since it removes potentially unused bindings. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes Layr-Labs#207 This PR introduces the following changes * Adds a CI workflow to check if the bindings are up to date. This works by re-generating the bindings and checking the diff against the existing bindings. * Changes the `make bindings` target to generate the bindings using a specific Foundry version. This is important since different Foundry versions may generate slightly different bindings, which will cause the CI to fail. To ensure a specific Foundry version is used, we run the command inside a Docker container that runs a pinned Foundry version (v0.3.0). * Updates the bindings by generating them with the modified `make bindings` target. **Note:** the existing `bindings` target was renamed to `bindings_host`, as it runs without Docker. However the `bindings_host` target is only for CI use only. To generate the bindings, please use the `bindings` target. - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Pablo Deymonnaz <[email protected]>
Fixes Layr-Labs#197 This PR introduces the following changes * Removes all the `alloy-*` reexported crates from the workspace dependencies, leaving only `alloy`. * Updates the workspace dependencies on every crate, removing the `alloy-*.workspace = true` imports and leaving only `alloy.workspace = true`. - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes Layr-Labs#206 ### What Changed? This PR removes the `crates/eigensdk/README.md` file and creates a symbolic link that points to the root `README.md` to keep it synced. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes Layr-Labs#238 ### What Changed? This PR adds a workflow that enforces the `CHANGELOG.md` file to be updated on every pull request. It is also required that the changes in the changelog include the pull request URL. **Important:** This check is skipped if the pull request includes the `changelog-ignore` label. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # ### What Changed? This PR adds a release document, intended as a checklist that maintainers go through to make a new release. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
The `Check bindings` CI job was failing due to mismatches in the bindings generated by the CI and the ones generated by the Docker container. This PR introduces the following changes: * Fixes the job by changing its ubuntu version from `latest` (24.04) to 22.04. With this change, the bindings generated by the CI are the same as the Docker container ones. * Changes the way the bindings are compared. Now it uses `git diff --exit-code` instead of copying the existing bindings and running `diff`. - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: ricomateo <[email protected]>
Fixes # ### What Changed? Correct contracts version in readme ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: supernovahs <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>
…ase` (Layr-Labs#269) Fixes Layr-Labs#264 ### What Changed? Add ECDSA bindings ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: harshit singhal <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>
### Motivation The previous CI job that checked whether the anvil state was up to date was actually not performing any comparison at all (it was mistakenly comparing empty files). Checking that the anvil state is up to date by re-generating it and comparing it with the existing one was not very practical since this approach is very time-sensitive: any difference in the timestamps generates a different state, which the CI wrongly takes as an outdated state. ### What Changed? This PR introduces the following changes in the CI: * Removes the step that compares the anvil state in the tests CI job, and simply checks that the script to generate the state works. * Adds a new job that checks whether the anvil state is updated (it runs only when the contracts change). ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <[email protected]>
Closes Layr-Labs#232 ### What Changed? release-plz ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # This PR moves the bindings generation logic to a script, to avoid having to install `make` in the docker image. - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Fixes # This PR syncs `dev` with `main` - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265
What Changed?
when starting service
operatorsinfo_inmemory
, the service starts to listen for new events while fetching operator state history. This avoid waiting to get the history then miss blocks.Reviewer Checklist
changelog-X
labels (if applies)