Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape/portrait consistency #192

Open
smtchahal opened this issue Sep 5, 2017 · 1 comment
Open

Landscape/portrait consistency #192

smtchahal opened this issue Sep 5, 2017 · 1 comment

Comments

@smtchahal
Copy link
Contributor

Why do some screen sizes have larger widths than heights but others don't? For instance, as of d171cb2, Sony Xperia Z5 Premium has a resolution of 3840x2160 in screens.json, so if you click on that device name on the web app, you get a landscape "preview" of the device screen. But Samsung Galaxy S6, S6 Edge has a saved resolution of 1400x2560, so clicking on that device name gives you a portrait preview.

This is confusing IMHO. Can we/do we have a consensus on which orientation (landscape or portrait) to use? Maybe we could have landscape orientation for tablets but portrait for phones?

@arkon
Copy link
Collaborator

arkon commented Sep 5, 2017

Probably just portrait for phones and whatever orientation is typical for other devices (e.g. a Nexus 10 would be landscape, but an iPad would be portrait).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants