Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Updated Riot API #16

Open
SeaRoth opened this issue May 8, 2017 · 10 comments
Open

[Request] Updated Riot API #16

SeaRoth opened this issue May 8, 2017 · 10 comments
Labels

Comments

@SeaRoth
Copy link

SeaRoth commented May 8, 2017

Will you be updating to SummonerV3 and MatchV3?

image

@m1so
Copy link

m1so commented May 8, 2017

I'm not sure what the plan is yet as the deprecation window is opened until the end of July. There have been significant changes in the API, such as removal of the batch calls, some endpoint and Dto changes, new rate limiting, etc. so a complete rewrite might be a possibility. However PRs are greatly appreciated at all times. If you have any questions or ideas for the update feel free to contact me on the Riot API Discord and I will try to get back to you as soon as possible.

@alabama
Copy link

alabama commented Jun 26, 2017

any updates so far?

@alabama
Copy link

alabama commented Jul 4, 2017

I would start working on the V3 branch and switch to the new API, any advise from you @m1so?

@m1so
Copy link

m1so commented Jul 5, 2017

Have a look at https://github.com/LeaguePHP/LeagueWrap/tree/v3 and the 'Roadmap' project https://github.com/LeaguePHP/LeagueWrap/projects/1

I've also prepared an async client which will be used to do batch requests as they are deprecated now (see Stats for usage).

@alabama
Copy link

alabama commented Jul 5, 2017

can you add me to members, i finished with a change for summoner api v3 and would like to commit to the V3 branch, that you can see how i would do this.

i could also just branch from V3 and we do this via pull-requests

@m1so
Copy link

m1so commented Jul 5, 2017

Yep, we can also move the discussion to the PR

@alabama
Copy link

alabama commented Jul 6, 2017

#17 here we go

@m1so
Copy link

m1so commented Jul 6, 2017

Honestly I'm thinking about recreating the lib from scratch and removing some features which aren't widely used (like attaching static data) or using dtos (most people use ->raw() in their questions anyway) to have a lightweight implementation. Also the rate limiting is a mess and I'd rather rework it to be pluggable with psr standard as well as provide integration for popular frameworks.

@alabama
Copy link

alabama commented Jul 6, 2017

I thinks recreating the lib is a good idea. Problem is the the deadline from riot. So the older api endpoints V1/V2 will be deprecated and not used after July 24th.
So it's not much time for recreating everything.

@m1so
Copy link

m1so commented Jul 24, 2017

Here is my initial implementation of v3 with lots of breaking changes and possible todos https://github.com/m1so/LeagueWrap, it should be up on packagist.

All the endpoints and Dto class are autogenerated so there is a lot of missing docblocks, but every endpoint is implemented and supports batch requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants