-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting deploy-type
environment variable
#9
Comments
|
@arobson any thoughts? |
NODE_ENV is something that folks already use and it's a familiar concept. Any reason why we should avoid piggy-backing on it? |
@arobson Its an interesting question because the use case for this flag is very specific. In most settings (local dev for instance), any env variables you have that could override config.json you would have set intentionally. So most likely, even if NODE_ENV=development you'd want your local env variables to be used instead of the config.json. It is really only on a production server where ENV variables are set that you might want to force a development config for some sort of debugging. With that usage in mind, I almost feel like a CONFIGYA specific flag might be best. |
Is there an actual way to set
deploy-type
from the command line? I think, due to the hyphen that you'd have to set it some other way than simply:Is this something we want to consider changing (while supporting the old syntax) to something specific to configya – or support the
NODE_ENV
variable instead?Thoughts?
The text was updated successfully, but these errors were encountered: