Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting deploy-type environment variable #9

Open
dcneiner opened this issue Dec 11, 2014 · 4 comments
Open

Setting deploy-type environment variable #9

dcneiner opened this issue Dec 11, 2014 · 4 comments

Comments

@dcneiner
Copy link
Contributor

Is there an actual way to set deploy-type from the command line? I think, due to the hyphen that you'd have to set it some other way than simply:

$ deploy-type=DEV npm start

Is this something we want to consider changing (while supporting the old syntax) to something specific to configya – or support the NODE_ENV variable instead?

Thoughts?

@dcneiner
Copy link
Contributor Author

CONFIGYA_MODE or CONFIGYA_ENV would be possible alternate names

@ifandelse
Copy link
Contributor

@arobson any thoughts?

@arobson
Copy link
Contributor

arobson commented Dec 11, 2014

NODE_ENV is something that folks already use and it's a familiar concept. Any reason why we should avoid piggy-backing on it?

@dcneiner
Copy link
Contributor Author

@arobson Its an interesting question because the use case for this flag is very specific. In most settings (local dev for instance), any env variables you have that could override config.json you would have set intentionally. So most likely, even if NODE_ENV=development you'd want your local env variables to be used instead of the config.json.

It is really only on a production server where ENV variables are set that you might want to force a development config for some sort of debugging. With that usage in mind, I almost feel like a CONFIGYA specific flag might be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants