API no registering if you use a non-standard API Prefix

[EneMarine]

Hello,

We just found out your plugin doesn't work if you edit the Wordpress Rest Prefix for security reasons.
Your method LP_Helper::isRestApiLP() use a hard coded value instead of using rest_get_url_prefix()

learnpress/inc/class-lp-helper.php

Line 441 in f4e6567

return strpos( self::getUrlCurrent(), '/wp-json/lp/' ) || strpos( self::getUrlCurrent(), '/wp-json/learnpress/' );

I would assume there is 2 solutions :

• Using rest_get_url_prefix

public static function isRestApiLP(): bool {
+       $restPrefix = rest_get_url_prefix();
-	return strpos( self::getUrlCurrent(), '/wp-json/lp/' ) || strpos( self::getUrlCurrent(), '/wp-json/learnpress/' );
+	return strpos( self::getUrlCurrent(), '/' . $restPrefix . '/lp/' ) || strpos( self::getUrlCurrent(), '/' . $restPrefix . '/learnpress/' );
}

• Adding a filter so developers can't edit this check

public static function isRestApiLP(): bool {
+       $isRestApiLP = strpos( self::getUrlCurrent(), '/wp-json/lp/' ) || strpos( self::getUrlCurrent(), '/wp-json/learnpress/' );
-	return strpos( self::getUrlCurrent(), '/wp-json/lp/' ) || strpos( self::getUrlCurrent(), '/wp-json/learnpress/' );
+	return apply_filters('learn_press_is_rest_api_lp', $isRestApiLP, self::getUrlCurrent());
}

Thanks

[tungnxt89]

Hi EneMarine

Thank you for you feedback, we don't know that before. We'll apply that.

Thanks.
Best regard!