Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output type enum #32

Open
1 of 11 tasks
Libbum opened this issue Jun 4, 2017 · 4 comments
Open
1 of 11 tasks

Output type enum #32

Libbum opened this issue Jun 4, 2017 · 4 comments
Assignees

Comments

@Libbum
Copy link
Owner

Libbum commented Jun 4, 2017

Now that I've implemented serde 1.0 in ndarray, we can serialise data. For the moment we have the ability to write csv, message pack, yaml and json. Config input is yaml, observables are json and potentials/wavefuntions are a 'choice' of 'binary or not', meaning messagepack/csv.

  • - Build an enum of these so people can chose their format
  • - matlab readers
    • - csv
    • - messagepack
    • - json
    • - yaml
  • - python readers
    • - csv
    • - messagepack
    • - json
    • - yaml
@Libbum Libbum self-assigned this Jun 4, 2017
@Libbum Libbum added this to the Initial release milestone Aug 20, 2017
@TheSirC
Copy link

TheSirC commented Oct 21, 2017

Hello,
I would like to tackle the MATLAB part of it if you are willing to mentor (answer basic questions, review my code). I might not be fast but I will notify you from any improvements.
Is it OK to you @Libbum ?

@Libbum
Copy link
Owner Author

Libbum commented Oct 21, 2017

Sure! I have some output already for Matlab, but it's not complete by any means. Go right ahead, I'll help out with any questions you may have.

@TheSirC
Copy link

TheSirC commented Oct 21, 2017

Where would you want me to put the files for the code? What name? Do you have some styling conventions? Could you write some tests you want the code I produce to pass? Some requirements maybe?

@Libbum
Copy link
Owner Author

Libbum commented Oct 21, 2017

I'm on the road this weekend so don't have too much time until Monday, but you can put any changes in analysis/matlab. I have a load_plain.m file there already that you can compare against. No specific conventions you'll need to follow, but these files would be for end users who want to plot data easily. So things need to be mostly self explanatory and we'll commented. That's the aim at least, but just getting things working is fine to start.

One blocking issue with this is that native loading of binary message pack data, yaml content etc. doesn't exist in Matlab. There are tools out there that we can use to pull this data in, finding the right ones with easy set-up and install has proven to be a bit of an issue so far...

Requirements here are a few proof of concept graphs to be able to display the resulting wavefunctions that Wafer is building. Since the data is 3D I personally like 2D slices and 3D ISO surfaces (the file I've written already has these), but if you can think of better ways of displaying the data then that would be a welcomed addition.

I'll elaborate a bit more on Monday. Thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants