Make libvisual-plugins require t1lib unless explicitly disabled?

[hartwork]

Current CMake output:

-- Could NOT find T1lib (missing:  T1LIB_LIBRARY T1LIB_INCLUDE_DIR) 
CMake Warning at CMakeLists.txt:162 (MESSAGE):
  T1lib not found.  The Dancing Particles plugin will not be built.

I would expect it to error out and recommend some option to build without it, if I really want to.

[kaixiong]

T1lib is required by the DancingParticles plugin and checked by CMake only if the plugin is enabled. Generally, all plugins are included in the build (as are their dependency checks) by default.

[stuaxo]

I couldn't work out how to get t1lib working in Ubuntu, might be a nice aspiration to move to freetype in this plugin.

[kaixiong]

Agreed. To get t1lib for building on Ubuntu/Debian, you can apt-get libt1-dev to pull in the necessary files.

[hartwork]

T1lib is required by the DancingParticles plugin and checked by CMake only if the plugin is enabled.
Generally, all plugins are included in the build (as are their dependency checks) by default.

Yes, but it seems the inclusiong of dacing particles is "shy". I would rather have it error out than just drop something silently, personally.

@stuaxo, please report back if installed libt1-dev works out for you (though not meaning to hurry).

[stuaxo]

Nope, can't install it on wily. Don't think it's been packaged + in Ubuntu repos for a while.

[hartwork]

It was removed, I see.
Have you used dget and/or debuild before? How far do you get with

dget --build http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.dsc

on Ubuntu?

[stuaxo]

Ah, maybe libt1-5 is it, renamed ?

[hartwork]

As libt1-dev depends on libt1-5 you will need that one too, but should have both or none: They are binary packages from the same source package t1lib (see http://packages.ubuntu.com/source/trusty/t1lib) and all of that seems to have gone after trusty/14.04. If that's what you're at, you should have them all available. Is it?

[stuaxo]

Nope, 15.10 (Wily).

[hartwork]

I see. How far do you get with the dget ..... command above?

[stuaxo]

Managed to miss this, was reading late at night - will give it a go when in front of relevant box

[kaixiong]

Yes, but it seems the inclusiong of dacing particles is "shy". I would rather have it error out than just drop something silently, personally.

That's a fair design, but unusual for non-core/optional components. We didn't go with that because it would require very explicit toggling of plugins for a successful build. Good for builders/developers but not so great for end users.

[stuaxo]

I tried the dget command but got stuck with gpg keys, also tried resolving this but didn't help:

Initial attempt:

$ dget --build http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.dsc
dget: retrieving http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.dsc
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1331  100  1331    0     0    276      0  0:00:04  0:00:04 --:--:--   402
dget: retrieving http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2.orig.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1828k  100 1828k    0     0  19997      0  0:01:33  0:01:33 --:--:-- 21115
dget: retrieving http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.diff.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0curl: (56) Recv failure: Connection reset by peer
dget: curl t1lib_5.1.2-3.6ubuntu1.diff.gz http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.diff.gz failed
E: Unable to find a source package for t1lib
t1lib_5.1.2-3.6ubuntu1.dsc:
dscverify: t1lib_5.1.2-3.6ubuntu1.dsc failed signature check:
gpg: Signature made Sun 29 Dec 2013 13:06:52 GMT using DSA key ID 0F932C9C
gpg: Can't check signature: public key not found
Validation FAILED!!

Try and get key

$ gpg --keyserver keyserver.ubuntu.com --recv-keys 0F932C9C
gpg: requesting key 0F932C9C from hkp server keyserver.ubuntu.com
gpg: key 0F932C9C: public key "Matthias Klose <[email protected]>" imported
gpg: 3 marginal(s) needed, 1 complete(s) needed, PGP trust model
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: Total number processed: 1
gpg:               imported: 1

But still fails -

$ dget --build http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.dsc
dget: retrieving http://archive.ubuntu.com/ubuntu/pool/main/t/t1lib/t1lib_5.1.2-3.6ubuntu1.dsc
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1331  100  1331    0     0    169      0  0:00:07  0:00:07 --:--:--    20
dget: using existing t1lib_5.1.2.orig.tar.gz
dget: using existing t1lib_5.1.2-3.6ubuntu1.diff.gz
t1lib_5.1.2-3.6ubuntu1.dsc:
dscverify: t1lib_5.1.2-3.6ubuntu1.dsc failed signature check:
gpg: Signature made Sun 29 Dec 2013 13:06:52 GMT using DSA key ID 0F932C9C
gpg: Can't check signature: public key not found
Validation FAILED!!

[hartwork]

@kaixiong, that's an interesting view. Let me think about it some more.

@stuaxo, I see. I guess you would need apt-get install debian-archive-keyring first. If you're lucky, the key is included with the wily version of that. I suppose when you loaded that key manually, it went to the wrong place. Also please note that short keys like "0F932C9C" are dangerous to use as collisions are too quick to make.

[kaixiong]

t1lib will be replaced with FreeType2. Code is currently pending testing and refinement. See #53.

[kaixiong]

FreeType2 adaptation of dancingparticles has been merged into master (#170).

[hartwork]

@kaixiong thanks, I'll close this ticket as "obsolete" then…

[kaixiong]

@hartwork hmm what about 0.4.x?

[hartwork]

@kaixiong we can reopen if you like, it's a question of view. Right now 0.4.x does not even build actor "dancingparticles" (#207).

[hartwork]

@kaixiong … though I think when I opened this ticket, it was less about t1lib in particular about control of the feature and its reporting where the build system does different things in 0.4.x anyway.