-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support ENSEMBL IDs #44
Comments
This code has been added to the function to support ENSEMBL IDs ` Check if all rownames start with "ENST"if (!all(grepl("^ENST", rownames(rse_tx)))) { Check patterns and perform operations based on the patternsif (all(grepl("^ENST.?\.", rownames(rse_tx)))) { |
Unit tests have been implemented here: qsvaR/tests/testthat/test-getDegTx.R Lines 60 to 67 in ec138a3
|
We should add a
is_gencode = TRUE
default argument such that when it's set toFALSE
, it matches using ENSEMBL IDs instead of Gencode IDs. Aka, it removes the trailing.[0-9]
in the IDs.This should include a unit test that checks the results using the same data with Gencode IDs, then manually makes them ENSEMBL IDs, and checks that with
is_gencode = FALSE
we get exactly the same results (might have to useset.seed()
on this unit test).The text was updated successfully, but these errors were encountered: