Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add from numbers import Number #1435

Merged
merged 1 commit into from
Nov 13, 2024
Merged

add from numbers import Number #1435

merged 1 commit into from
Nov 13, 2024

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Nov 13, 2024

What does this PR do?

It doesn't seem that Number is imported but it is used

lightning-thunder/thunder/core/transform_common.py

Line 41 in 8f5026f

primal: Proxy | Number
.
So add an import statement for clarity.

@crcrpar
import Number
8cce4ed 
Signed-off-by: Masaki Kozuki <[email protected]>
mruberry
mruberry approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry mruberry merged commit 3d27367 into main Nov 13, 2024
41 checks passed
@mruberry mruberry deleted the crpa/missing-import-number branch November 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crcrpar @mruberry