Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to use dataloader_idx in log name in LightningModule.log #20485

Open
lokesh-vr-17773 opened this issue Dec 10, 2024 · 1 comment
Open
Labels
feature Is an improvement or enhancement

Comments

@lokesh-vr-17773
Copy link

lokesh-vr-17773 commented Dec 10, 2024

Description & Motivation

Allow the user to include dataloader information in the log name when add_datalaoder_idx is set to False.

Pitch

Since LightningModule.log includes the add_dataloader_idx flag for logging, it is beneficial to allow users to include dataloader information in the log name when add_dataloader_idx is set to False. This aligns with the intended purpose of the add_dataloader_idx flag.

Proposed change:

if add_dataloader_idx and "/dataloader_idx_" in name:
  raise MisconfigurationException()

Alternatives

No response

Additional context

No response

cc @Borda

@lokesh-vr-17773 lokesh-vr-17773 added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Dec 10, 2024
@lantiga
Copy link
Collaborator

lantiga commented Dec 11, 2024

Makes sense, would you like to send in a quick PR? Also it would be great if you could summarize why this is important for you as a user by providing a real-world case.

@lantiga lantiga removed the needs triage Waiting to be triaged by maintainers label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants