Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update self.log #132

Open
loodvn opened this issue Jan 7, 2022 · 2 comments
Open

Update self.log #132

loodvn opened this issue Jan 7, 2022 · 2 comments
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@loodvn
Copy link

loodvn commented Jan 7, 2022

🐛 Bug

Some tutorials still return non-detached tensors in training_step - this is deprecated in 1.6 and may cause memory leaks if people follow those patterns.

e.g.
output = OrderedDict({"loss": g_loss, "progress_bar": tqdm_dict, "log": tqdm_dict})

The error pops up in the autogenerated docs here: https://pytorch-lightning.readthedocs.io/en/stable/notebooks/lightning_examples/basic-gan.html

I raised this in Lightning-Universe/lightning-bolts#793 too.

I see the examples in https://github.com/PyTorchLightning/pytorch-lightning/tree/master/pl_examples already defer to lightning bolts for more robust examples - wherever a good source of docs/best practices should be, I think this specific error be fixed? (these examples are also discussed in #71).

Thanks, loving the library btw! :)

@loodvn loodvn added bug / fix Something isn't working help wanted Extra attention is needed labels Jan 7, 2022
@Borda
Copy link
Member

Borda commented Jan 7, 2022

Hi @loodvn are you interested in sending out fix? :]

@loodvn
Copy link
Author

loodvn commented Jan 17, 2022

Unfortunately not, sorry - Lightning-Universe/lightning-bolts#793 (comment)

@stale stale bot added the won't fix This will not be worked on label Mar 20, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Mar 21, 2022
@stale stale bot closed this as completed Apr 17, 2022
@Borda Borda reopened this Apr 17, 2022
@stale stale bot removed the won't fix This will not be worked on label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants