diff --git a/.github/actions/pkg-install/action.yml b/.github/actions/pkg-install/action.yml index 100a52e8..d74e752b 100644 --- a/.github/actions/pkg-install/action.yml +++ b/.github/actions/pkg-install/action.yml @@ -17,7 +17,7 @@ inputs: description: "additional pip install flags" required: false default: "-f https://download.pytorch.org/whl/cpu/torch_stable.html" - custom-import: + custom-import-code: description: "additional import statement, need to be full python code" required: false default: "" @@ -56,9 +56,9 @@ runs: shell: bash - name: package check / custom import - if: ${{ inputs.custom-import != '' }} + if: ${{ inputs.custom-import-code != '' }} run: | - python -c '${{ inputs.custom-import }}' + python -c '${{ inputs.custom-import-code }}' shell: bash - name: Uninstall all @@ -81,5 +81,5 @@ runs: run: | set -ex python -c "import ${{ inputs.import-name }} as pkg; print(f'version: {pkg.__version__}')" - python -c '${{ inputs.custom-import }}' + python -c '${{ inputs.custom-import-code }}' shell: bash diff --git a/.github/workflows/check-package.yml b/.github/workflows/check-package.yml index a1ddbd00..64361321 100644 --- a/.github/workflows/check-package.yml +++ b/.github/workflows/check-package.yml @@ -25,7 +25,7 @@ on: description: "Import name to test with after installation" required: true type: string - custom-import: + custom-import-code: description: "additional import statement, need to be full python code" type: string required: false @@ -143,7 +143,7 @@ jobs: pkg-extras: ${{ inputs.install-extras }} pip-flags: ${{ inputs.install-flags }} import-name: ${{ inputs.import-name }} - custom-import: ${{ inputs.custom-import }} + custom-import-code: ${{ inputs.custom-import-code }} # TODO: add run doctests diff --git a/.github/workflows/ci-use-checks.yaml b/.github/workflows/ci-use-checks.yaml index afc1670c..bfafc9c7 100644 --- a/.github/workflows/ci-use-checks.yaml +++ b/.github/workflows/ci-use-checks.yaml @@ -64,7 +64,7 @@ jobs: install-extras: "[cli]" # todo: when we have a module with depence on extra, replace it # tried to import `lightning_utilities.cli.__main__` but told me it does not exits - custom-import: "import fire" + custom-import-code: "import fire" testing-matrix: | { "os": ["ubuntu-22.04", "macos-13", "windows-2022"], diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e9b992b..ca7473b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 --- +## [Unreleased] - 2024-MM-DD + +### Changed + +- CI: split and rename `custom-import` to `custom-import-code` + + ## [0.11.8] - 2024-10-15 ### Changed