Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements not defined #23

Open
tflori opened this issue Mar 11, 2022 · 2 comments
Open

Requirements not defined #23

tflori opened this issue Mar 11, 2022 · 2 comments

Comments

@tflori
Copy link

tflori commented Mar 11, 2022

We came across this issue because the our library runs unit tests in the CI pipeline on php 7.1 up to php 8.0. When defining the requirement phpunit/phpunit with * it installs what ever is compatible to the current tested php version. But limedeck/phpunit-detailed-printer * always installs version 6.

In fact phpunit is not just a requirement for developement but also for production. In order to solve that every major version needs an update with the requirement of phpunit version.

If you want I can prepare some merge requests.

@jakubhomoly
Copy link
Collaborator

Please refer to the version compatibility table. We have a major release of our package for every related major PHPUnit release.

@tflori
Copy link
Author

tflori commented Mar 11, 2022

It is not about my ability to read it is about the ability of composer to chose the correct version. Defining a dependency as dev-dependency means that this dependency is only required when I develop phpunit-detailed-printer but this version of phpunit is required when I use phpunit-detailed-printer.

here are two example pull requests: #25 #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants