Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub actions and master branch protection for repository #17

Open
mtimoustafa opened this issue May 3, 2024 · 3 comments
Open

Comments

@mtimoustafa
Copy link
Collaborator

Hi @TynanSylvester / @Ludeon,

I'm looking to enable GitHub Actions on this repository, to add automation to the translation files. Also, it would be best to add push protections to the master branch to prevent commits outside of a pull request. This would ensure better quality of commits through a review process.

I'm also happy to manage those permissions myself; I'm currently a member of the repo but not a maintainer. Is it okay to give us higher permissions here?

This is all part of a process by me and @CGUltimateno to revitalize this translation effort, and make it easier for others to contribute without much technical knowledge.

Thanks!

@mtimoustafa
Copy link
Collaborator Author

More context:

Here's the relevant PR for me starting to add the GH action: #16.

This should integrate the RimTranslate tool, which should allow translators to use a program like POEdit to intuitively edit the translation files, as opposed to manually editing the XML. With some rudimentary knowledge of GitHub codespaces / git, it should be easy for them to open a PR with the edited files.

@mtimoustafa
Copy link
Collaborator Author

My bad, I see GH actions are already enabled under https://github.com/Ludeon/RimWorld-ar/actions 🙏🏽 The master branch issue is still pertinent though.

@LudeonBusiness
Copy link

We've added the master pull request rule and will be adding you and @CGUltimateno as maintainers.

Hopefully this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants