Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support of PHP 7.3+ #278

Closed
wants to merge 1 commit into from
Closed

support of PHP 7.3+ #278

wants to merge 1 commit into from

Conversation

forgie1
Copy link

@forgie1 forgie1 commented Jun 3, 2020

closes #276

@karens
Copy link
Member

karens commented Jun 25, 2020

The update of Sebastian/diff to 4 will probably be a problem in some Drupal sites. Even a clean checkout of Drupal 9 is on Sebastian/diff 3.0.2.

I don't know the rational for that change.

@karens
Copy link
Member

karens commented Jun 25, 2020

Requiring a minimum of 7.3 also means this might not work on Drupal 8. So I don't want to go that far. A minimum of php 7.2 is better.

@karens
Copy link
Member

karens commented Jun 26, 2020

I'm adding 7.3 and 7.4 in #280. Don't want to drop 5.5 yet since there could still be Drupal 7 sites using it.

@karens karens closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support of PHP 7.4
2 participants
@forgie1 @karens