Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[H5PEditor]: saveOrUpdateContentReturnMetaData has incorrect signature for metadata #2675

Open
JPSchellenberg opened this issue Nov 27, 2022 · 0 comments
Labels
[type] bug Something isn't working (resulting in patch-version)

Comments

@JPSchellenberg
Copy link
Member

saveOrUpdateContentReturnMetaData has H5P.IContentMetadata as type for the metadata. But H5P.IContentMetadata is actually the type return from the server to the client.

saveOrUpdateContentReturnMetaData is called by the client and the metadata structure that is send is:

authors: IContentAuthor[];
changes: IContentChange[];
defaultLanguage: string;
extraTitle: string;
license: string;
title: string;

which is missing embedTypes, language, mainLibrary, preloadDependencies.

@JPSchellenberg JPSchellenberg added the [type] bug Something isn't working (resulting in patch-version) label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[type] bug Something isn't working (resulting in patch-version)
Projects
None yet
Development

No branches or pull requests

1 participant