Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCHPRS 0.5.1 (for mc 1.20.4) slow like as MC vanilla with carpet mod #183

Open
IUM259 opened this issue Feb 9, 2025 · 4 comments
Open

Comments

@IUM259
Copy link

IUM259 commented Feb 9, 2025

Hi people, how are you? I want to say that I tried using mchprs 0.5.1 for mc 1.20.4 but when doing /rtps it is still extremely slow compared to what the version for mc 1.18.2 was, mchprs 0.5.1 even if I set the rtps to maximum runs just as fast as MC 1.20.4 with carpet mod at maximum ticks rate. Before with the other mchprs (for mc 1.18.2) I only loaded the schematic, did /rtps 100000 (which was the maximum allowed) and it was super fast, it really helped me to do the tests, but now it happens that I updated the world to 1.20.4 and made big changes (like downgrading) and it turns out that mchprs works the same as without using it. Some people told me about "/rp c -io" but when I do that the pot crashes. Please note that I am re nab with mchprs maybe I am not doing something right. Please can you tell me step by step how to run fast mchprs?

@BramOtte
Copy link
Contributor

BramOtte commented Feb 9, 2025

Do you also experience more slow down than before when in both cases not using the optimization flags? And if so how large is the difference?

Also the crashing when using optimization flags is a bug, likely in the constant coalescence pass, and should be fixed with PR #182.

@IUM259
Copy link
Author

IUM259 commented Feb 10, 2025

ill try recompile mchprs with the file changed for ussue 182, and ill tell u later the results, mb is slow bcuz i cannot do "/rp c -io" for the plot crash

@IUM259
Copy link
Author

IUM259 commented Feb 10, 2025

I tested it, "/rp c -io" was successfully executed without crashing the plot.
On the other hand, /rtps executed in the following way is extremely slow compared to mchprs for mc 1.18.2, it behaves very similar to mc with carpet mod.
/rtps execution order used by mchprs (any version)

  1. load schematic.
  2. paste schematic.
  3. /rtps (the maximum allowed) (100000 for 1.18.2 and 1000000000 for 1.20.4, I also tried 100000 for the latter in case 1000000000 was too much and in case that value was still under review)
  4. wait for it to compile (in 1.18.2 it compiles automatically, in 1.20.4 I have to do /redpiler compile)
  5. speed test of the circuit: 1.18.2 super-fast, 1.20.4 similar to MC vanilla with carpet mod.

What I was able to do is /radv which is very effective, it responds quickly but I don't see anything that happens in the middle of the process, it directly jumps to the tick I put (it's correct) but it's not the same as /rtps.

@IUM259
Copy link
Author

IUM259 commented Feb 10, 2025

No problem, I was able to downgrade to version 1.18.2, apparently just the Sign were cleaned. I'm going to make the improvements in mc 1.20.4 anyway, then I'll downgrade a copy to test in mchprs for 1.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants