Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch everything touching PyPi to OpenID connect #4326

Closed
IAlibay opened this issue Oct 27, 2023 · 15 comments
Closed

Switch everything touching PyPi to OpenID connect #4326

IAlibay opened this issue Oct 27, 2023 · 15 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 27, 2023

The recommend workflow for uploading things to PyPi is now through OpenID connect.

I've yet to get to grips with the full pipeline for this, so I'll slowly start doing migrations.

There's a bunch of things I don't have keys for, so I'll be pinging folks for access or to update things themselves as things progress.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

MDA direct repos to update:

MDAKits under the org:

MDAKits under the org that don't have deployment workflows but we should still know who has access:

@orbeckst
Copy link
Member

Thanks for collecting the list and getting the process started. Let me know if you need anything. I don't know what one has to do in order to enable OpenID on PyPi.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

Thanks for collecting the list and getting the process started. Let me know if you need anything. I don't know what one has to do in order to enable OpenID on PyPi.

I've not tried a deployment yet, but it's not that much work, you just need to know the right yaml file & environment - https://docs.pypi.org/trusted-publishers/adding-a-publisher/

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

@jbarnoud I don't have management access to panedr on pypi - could you add the trusted publisher or add me as a manager?

@jbarnoud
Copy link
Contributor

jbarnoud commented Oct 27, 2023 via email

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

I just made you owner on pypi.

On 27 October 2023 19:06:13 CEST, Irfan Alibay @.> wrote: @jbarnoud I don't have management access to panedr on pypi - could you add the trusted publisher or add me as a manager? -- Reply to this email directly or view it on GitHub: #4326 (comment) You are receiving this because you were mentioned. Message ID: @.>

Thanks!

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

Putting on my coredev hat for a second - there are at least a couple of sole ownership projects across the org, that's rather dangerous.

Could I ask that anything which we end up having maintenance of have at least two coredevs in charge?

Pinging @lilyminium for the sphinx theme and @orbeckst for pathsimanalysis and waterdynamics.

Not sure what the deal is with maintenance of membrane-curvature and solvation-analysis, pinging @ojeda-e and @orionarcher for discussion.

@orbeckst
Copy link
Member

@IAlibay (as IAlibay) was invited for pathsimanalysis but the invite expired. I re-invited you for pathsimanalysis and also for waterdynamics.

@orbeckst
Copy link
Member

Added more invites for IAlibay:

  • pypi: pytng
  • testpypi: waterdynamics, pathsimanalysis, mdaencore

There's no testpypi pytng. — do you want to create it @IAlibay ?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

There's no testpypi pytng. — do you want to create it @IAlibay ?

Yes, it's a good opportunity to test out the next "anticipated publishing" portion of PyPi!

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

Ok I'm stopping at the core library upstream dependencies for now - we haven't tried an actual deployment beyond the pypi-deployment tests, so it's possible that all the PRs I've opened aren't 100% correct.

I propose we merge the PyTNG one and then do a release and see how that goes?

@orbeckst
Copy link
Member

sounds good, 🤞

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

pytng went up fine - everything else should work (assuming no typos).

@lilyminium
Copy link
Member

I added GH as a trusted publisher and also @IAlibay and @orbeckst as owners to mda-sphinx-theme on pypi and testpypi.

@orbeckst
Copy link
Member

orbeckst commented Oct 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants