add default None -> UserWarning #4747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4747 +/- ##
===========================================
- Coverage 93.65% 93.62% -0.03%
===========================================
Files 175 187 +12
Lines 21564 22630 +1066
Branches 3023 3023
===========================================
+ Hits 20195 21188 +993
- Misses 925 998 +73
Partials 444 444 ☔ View full report in Codecov by Sentry. |
tylerjereddy
approved these changes
Oct 20, 2024
| # https://docs.python.org/3/library/warnings.html#warnings.warn | ||
| # if category is None, the default UserWarning is used | ||
| if category is None: | ||
| category = UserWarning |
There was a problem hiding this comment.
Ah, this is a surprisingly simple fix, very nice. Confirming it also works in my hands.
I'll approve but not merge yet given the release cycle situation.
IAlibay
requested changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4746
Changes made in this Pull Request:
category=NonetoUserWarningby defaultWe don't appear to test our utilities anywhere so I haven't added a formal test -- but running it with #4744 worked.
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4747.org.readthedocs.build/en/4747/