Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept arrays in feature functions #7

Open
tsalo opened this issue Nov 4, 2020 · 2 comments
Open

Accept arrays in feature functions #7

tsalo opened this issue Nov 4, 2020 · 2 comments
Labels
Effort: Medium Enhancement New feature or request Impact: High Priority: Medium Tests Pytest and automatic testing on CircleCI

Comments

@tsalo
Copy link
Member

tsalo commented Nov 4, 2020

Summary

To reduce the number of temporary files we may need to write, we should allow the feature functions to accept arrays in addition to files.

Additional Detail

Next Steps

  1. Check datatypes of inputs to feature functions. If str, load the file. If array, use that directly.
  2. Update the docstrings.
  3. Add tests for both types of inputs.
@tsalo tsalo changed the title Accepts arrays in feature functions Accept arrays in feature functions Nov 4, 2020
@eurunuela eurunuela transferred this issue from Brainhack-Donostia/ica-aroma-org Nov 10, 2020
@eurunuela eurunuela added Enhancement New feature or request Tests Pytest and automatic testing on CircleCI labels Nov 11, 2020
@vinferrer
Copy link
Collaborator

Should we wait for complete python implementation? is because i am seeing the inputs and most of the time is something generated by melodic

@eurunuela
Copy link
Collaborator

Indeed, we cannot work on this issue until we drop MELODIC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Medium Enhancement New feature or request Impact: High Priority: Medium Tests Pytest and automatic testing on CircleCI
Projects
Status: Todo
Development

No branches or pull requests

3 participants