Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark CI failure/improvement #750

Open
sbryngelson opened this issue Nov 30, 2024 · 0 comments
Open

Benchmark CI failure/improvement #750

sbryngelson opened this issue Nov 30, 2024 · 0 comments
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

Right now the benchmark CI workflow prints useful information about grind time and runtime to the CI output. This CI workflow always passes, so long as the code executes.

I would like the CI to fail if the master and PR runtime or grind times are sufficiently different (within some tolerance). Without this, it is easy to have a performance regression but not see it because one did not check CI carefully enough.

@sbryngelson sbryngelson added enhancement New feature or request continuous-integration Continuous integration (CI) labels Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request
Development

No branches or pull requests

1 participant