Making TLP and PAP taxonomy adhere to FIRST standard (color and uppercase value) #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the pull-request. Before merging, I would propose the following (let me know what you think):
|
|
Keeping both tags is a good solution. I added it back. Thanks for your fast answer ! |
|
Thank you for the quick update. I'll review the CI tomorrow and check for the TLP namespace part being uppercase. |
|
We will need to review the code base in MISP about the exclusion handling like we did for TLP before merging it. |
adulau
added a commit
that referenced
this pull request
Nov 22, 2023
|
Based on our discussion at FIRST-CTI, I made two commits based on your pull-request 873fc62 and 6efa8c3. This should solve the pending issue. We will announce the change in the next release of MISP in the next days. Thanks again for your work. I'll add the reference to CERT-FR sharing policy in the blog post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, in order to fix #86: