From d96433db64f35ba88838f87b2a2345c01c75c27a Mon Sep 17 00:00:00 2001 From: Luis Vasquez Date: Sun, 10 Nov 2024 21:00:09 +0100 Subject: [PATCH] Update `REVIEW` tag for MIT-CAVE/cave_static#507 --- cave_api/cave_api/examples/kitchen_sink.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/cave_api/cave_api/examples/kitchen_sink.py b/cave_api/cave_api/examples/kitchen_sink.py index 2ef43bd..2c96b6b 100644 --- a/cave_api/cave_api/examples/kitchen_sink.py +++ b/cave_api/cave_api/examples/kitchen_sink.py @@ -930,12 +930,14 @@ def execute_command(session_data, socket, command="init", **kwargs): } }, # REVIEW: - # Current implemented behavior on `cave_static`: `colorBy` and `sizeB`` dropdowns are populated with props + # Current implemented behavior on `cave_static`: `colorBy` and `sizeBy` dropdowns are populated with props # that have at least one gradient/color or size range/option value after left-merging # `legendGroups.lga.data.nodeTypeA.props` with `mapFeatures.data.nodeTypeA.props`. - # We could define a list of prop keys to specify which props should appear in the dropdowns by using - # `colorByOptions` and `sizeByOptions`. Note that `colorByOptions` and `sizeByOptions` are now different - # from the old structure and will only point to the keys. + + # REVIEW: The following is not implemented yet: + # I think we could define a list of prop keys to specify which props should appear in the dropdowns by + # using `colorByOptions` and `sizeByOptions`. Note that `colorByOptions` and `sizeByOptions` would be + # different from the old structure and will only point to the keys. "colorByOptions": [], "sizeByOptions": [], },